-
Couldn't load subscription status.
- Fork 185
feat(fill): pass blobParams into t8n binary #2264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fill): pass blobParams into t8n binary #2264
Conversation
220b7cf to
030733b
Compare
|
coverted to draft b/c maybe we should send more in that JSON (to include |
|
Ready to review. The version pushed now will process (in line with ipsilon/evmone#1330) an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing this, some comments.
113ff32 to
5decc1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Some comments!
e88cb15 to
3425eb7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just needs a fix for CI to fill the ShanghaiToCancun tests (I cant seem to push to the branch otherwise I would have):
Just needs a small change to fix CI:
--- a/src/ethereum_clis/transition_tool.py
+++ b/src/ethereum_clis/transition_tool.py
@@ -202,7 +202,9 @@ class TransitionTool(EthereumCLI):
fork_name = self.fork.fork_at(
block_number=self.env.number, timestamp=self.env.timestamp
).name()
- return self.blob_schedule[fork_name]
+ # Only return blob params if this fork has them
+ if fork_name in self.blob_schedule.root:
+ return self.blob_schedule[fork_name]
return NoneCo-authored-by: spencer <[email protected]>
3425eb7 to
1d3a8ac
Compare
ποΈ Description
The blobParams.json is required by evmone-t8n tool now, in order to fill tests correctly.
Appropriate change on the evmone end: ipsilon/evmone#1330
π Related Issues or PRs
N/A.
β Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlinttype(scope):.