Skip to content

Conversation

@pdobacz
Copy link
Contributor

@pdobacz pdobacz commented Oct 4, 2025

πŸ—’οΈ Description

The blobParams.json is required by evmone-t8n tool now, in order to fill tests correctly.

Appropriate change on the evmone end: ipsilon/evmone#1330

πŸ”— Related Issues or PRs

N/A.

βœ… Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@pdobacz pdobacz force-pushed the feat/t8n-filesystem-blob-schedule branch 2 times, most recently from 220b7cf to 030733b Compare October 6, 2025 08:11
@pdobacz pdobacz marked this pull request as draft October 6, 2025 09:01
@pdobacz
Copy link
Contributor Author

pdobacz commented Oct 6, 2025

coverted to draft b/c maybe we should send more in that JSON (to include network and (future) ...Time fields to be able to t8n in e.g. BPO1)

@pdobacz pdobacz marked this pull request as ready for review October 7, 2025 08:13
@pdobacz
Copy link
Contributor Author

pdobacz commented Oct 7, 2025

Ready to review. The version pushed now will process (in line with ipsilon/evmone#1330) an --input.config argument and JSON, so that end-game schedule (with ...Time) fields is support-able, doesn't worry about handling fill --fork OsakaToBPO1AtTime15k, for now. AFAIK this doesn't break any existing fill-capabilities of evmone, so we can maybe think about providing them as a 2nd step

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this, some comments.

@pdobacz pdobacz force-pushed the feat/t8n-filesystem-blob-schedule branch 2 times, most recently from 113ff32 to 5decc1d Compare October 10, 2025 09:56
@pdobacz pdobacz requested a review from marioevz October 10, 2025 14:35
Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some comments!

@pdobacz pdobacz force-pushed the feat/t8n-filesystem-blob-schedule branch from e88cb15 to 3425eb7 Compare October 14, 2025 18:43
Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just needs a fix for CI to fill the ShanghaiToCancun tests (I cant seem to push to the branch otherwise I would have):

Just needs a small change to fix CI:
--- a/src/ethereum_clis/transition_tool.py
+++ b/src/ethereum_clis/transition_tool.py
@@ -202,7 +202,9 @@ class TransitionTool(EthereumCLI):
                 fork_name = self.fork.fork_at(
                     block_number=self.env.number, timestamp=self.env.timestamp
                 ).name()
-                return self.blob_schedule[fork_name]
+                # Only return blob params if this fork has them
+                if fork_name in self.blob_schedule.root:
+                    return self.blob_schedule[fork_name]
             return None

@pdobacz pdobacz force-pushed the feat/t8n-filesystem-blob-schedule branch from 3425eb7 to 1d3a8ac Compare October 15, 2025 16:51
@pdobacz pdobacz changed the title feat(fill): pass blobSchedule into t8n binary feat(fill): pass blobParams into t8n binary Oct 15, 2025
@marioevz marioevz merged commit c6b99ee into ethereum:main Oct 15, 2025
15 checks passed
@marioevz marioevz deleted the feat/t8n-filesystem-blob-schedule branch October 15, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants