Skip to content

fix(tests): Fix test expectations for BAL oog tests #2293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 13, 2025
Merged

fix(tests): Fix test expectations for BAL oog tests #2293

merged 3 commits into from
Oct 13, 2025

Conversation

@fselmo
Copy link
Collaborator

@fselmo fselmo commented Oct 13, 2025 •
edited
Loading

🗒️ Description

  • Fix test expectations that didn't catch issues in the specs when validating.
  • Fix gas calculation for extcodecopy

These test should all fill with the PR at fselmo/execution-specs#17

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks: 
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@fselmo fselmo added type:bug Something isn't working scope:tests Scope: Changes EL client test cases in `./tests` fork: amsterdam Amsterdam hard fork labels Oct 13, 2025
spencer-tb
spencer-tb approved these changes Oct 13, 2025
View reviewed changes
Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fills for me! LGTM

Feel free to merge but could be worth waiting for your EELS PR to be merged, get the new commit and update the resolver... but then the Weld so doesn't really matter lol

@fselmo fselmo merged commit 67f596d into ethereum:main Oct 13, 2025
16 checks passed
@fselmo fselmo deleted the fix/oog-bal-tests branch October 13, 2025 14:23
kclowes pushed a commit to kclowes/execution-spec-tests that referenced this pull request Oct 20, 2025
@fselmo
fix(tests): Fix test expectations for BAL oog tests (ethereum#2293)
815d726 
* fix(tests): Fix test expectations for BAL oog tests

* chore: update Amsterdam commit hash for resolver

* chore: add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spencer-tb spencer-tb spencer-tb approved these changes

Assignees

No one assigned

Labels

fork: amsterdam Amsterdam hard fork scope:tests Scope: Changes EL client test cases in `./tests` type:bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fselmo @spencer-tb