feat(pytest,tests): tests added by fork introduced #423
Conversation
spencer-tb
added
scope:pytest
| fork_folder = metafunc.module.__name__.split(".")[1].capitalize() | ||
| if globals()[fork_name] < globals()[fork_folder]: | ||
| pytest.fail( | ||
| f"Incorrect usage of '{validity_marker_name}'. The validity marker fork " | ||
| f"'{fork_name}' must be greater than or equal to the test folder fork '{fork_folder}'." | ||
| ) |
There was a problem hiding this comment.
Validity marker check. Note this required us to move some existing tests or change the fork name.
| @@ -39,7 +39,7 @@ def env(): # noqa: D103 | |||
| ) | |||
|
|
|||
|
|
|||
| @pytest.mark.valid_from("Paris") | |||
| @pytest.mark.valid_from("Cancun") | |||
There was a problem hiding this comment.
Note this is still in Draft. I changed these to Cancun for now such that these tests pass the validity marker check.
What do we do in cases like this? To me if a test is valid before the fork where the eip or feature is introduced, it should not exist within that fork folder.
Are they specific to eip6780 or selfdestruct? If its the latter, I think we should move them to Homestead (where selfdestruct was introduced, well renamed from SUICIDE -> SELFDESTRUCT). Then mark them valid from the forks as is currently without the change.
spencer-tb
force-pushed
the
docs/specify-adding-tests-to-fork-introduced
branch
from
c827ddb to
d22bdf1
Compare
spencer-tb
force-pushed
the
docs/specify-adding-tests-to-fork-introduced
branch
from
d22bdf1 to
f2ca3ad
Compare
| from ethereum_test_forks import ( # noqa: F401 | ||
| Berlin, | ||
| Byzantium, | ||
| Cancun, | ||
| Constantinople, |
There was a problem hiding this comment.
I would like to find a better way to this, but its needed forglobals()[fork]
|
up |
🗒️ Description
In the past we have had confusion on where tests should be added regarding the folder structure.
This PR aims to:
valid_froma fork < the fork folder a test lies within.Primary additions currently
valid_frompytest marker is utilized correctly.valid_fromfork must be greater than or equal to the fork folder the test is added.Please note comments added below for further discussion.
🔗 Related Issues
Requires #418 for the yul test to compile from Frontier.
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.