-
Notifications
You must be signed in to change notification settings - Fork 122
all: Trace types #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marioevz
wants to merge
24
commits into
ethereum:main
Choose a base branch
from
marioevz:evm-trace-types
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
all: Trace types #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36f49bc
to
3ea278e
Compare
ef58822
to
d37bff4
Compare
I think this could be rebased after wait until #792 is merged. |
winsvega
approved these changes
Apr 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the dependency is merged.
this one allows to expect exception from vmtrace log?
like stack underflow?
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
scope:tools
Scope: Changes ethereum_test_tools package
type:feat
type: Feature
type:refactor
Type: Refactor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
TraceableException
) which selects relevant traces from the full EVM trace:E.g. in this case, the test failed because it expected a certain storage value at address 0x0000000000000000000000000000000000000100, so the trace printer detected the call frame returned from the address with an error and printed this line and a few previous lines:
Requires:
ethereum/go-ethereum#29212ethereum/go-ethereum#29248ethereum/go-ethereum#29353🔗 Related Issues
None
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.