Update the type for blob_gas_used
#1161
Conversation
src/ethereum/arrow_glacier/fork.py
Outdated
| tx: Transaction, | ||
| index: Uint, | ||
| ) -> None: | ||
| env: vm.Environment, tx: Transaction |
There was a problem hiding this comment.
The blob_gas_used was introduced in Cancun and as such should only affect the Cancun and the Prague fork folders. The code in the earlier forks folders should not change unless we are back-porting something.
There was a problem hiding this comment.
umm, actually these changes are not made by me. Maybe they got included while I was rebasing the branch. Can you suggest what should i do ?
There was a problem hiding this comment.
Hmm. Adding a commit with the relevant changes on top of the current forks/prague would be the cleanest way to handle this imo. Let me know if you need any further details.
There was a problem hiding this comment.
@gurukamath Sorry but I am not exactly sure how to handle this. Should i create a new branch and cherry-pick only the feature commit or is there any other alternative?
There was a problem hiding this comment.
@gurukamath, I cherry-picked the commits into a new feature branch and then force pushed it to the current branch,
gurukamath
changed the title
blob_gas_used
Shashwat-Nautiyal
force-pushed
the
blob_gas_used
branch
from
37491e8 to
cedf1bc
Compare
|
There are some linting issues with static code checks. You can find out the issues by running the command tox -e static. I would also suggest you to run tox -e py3 locally to make sure all the tests are passing. |
Shashwat-Nautiyal
force-pushed
the
blob_gas_used
branch
from
b3b3d84 to
5b0d0c1
Compare
What was wrong?
The blob_gas_used variable had inconsistent types across the repo. Somewhere U64 and somewhere Uint.
Related to Issue #1125
How was it fixed?
I updated the type of blob_gas_used to U64 across all files. Ensured to also update the return types of functions that populated the blob_gas_used variable.
Cute Animal Picture