-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codecov config file, excluded glacier & dao forks, add codecov badge to README #1168
base: master
Are you sure you want to change the base?
Add codecov config file, excluded glacier & dao forks, add codecov badge to README #1168
Conversation
0ddef70
to
105698e
Compare
105698e
to
e7b0a18
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1168 +/- ##
==========================================
- Coverage 84.87% 83.86% -1.02%
==========================================
Files 649 649
Lines 36122 36122
Branches 0 3224 +3224
==========================================
- Hits 30659 30293 -366
Misses 5463 5463
- Partials 0 366 +366
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I hope you don't mind, but I took a quick look at pytest-cov's documentation, and it looks like we can exclude directories earlier in the process. We could maybe add a section like this to [tool.coverage.run]
omit = [
"src/ethereum/*_glacier/*",
"src/ethereum/dao_fork/*",
] |
Not at all, this is good! I'll update the PR |
01205f5
to
83ee3c3
Compare
…rt on test failure
83ee3c3
to
a132f93
Compare
Looks like codecov is still counting the glacier forks... I wonder if it has something to do with how tox is passing the path? In the console output, we have lines like:
Perhaps the glob we need to use is |
For future PRs, prefer rebase over merge commits please! |
What was wrong?
Code coverage unfairly included glacier forks and the dao fork, for which we will not create tests
Closes issues #1139 and #1141
How was it fixed?
Excluded glacier forks in config file
Cute Animal Picture