-
Notifications
You must be signed in to change notification settings - Fork 376
chore(test-tools): re-enable eip checklist docs unit tests #1740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
packages/testing/src/execution_testing/checklists/tests/test_checklist_template_consistency.py
Outdated
Show resolved
Hide resolved
...testing/src/execution_testing/cli/pytest_commands/plugins/filler/tests/test_eip_checklist.py
Outdated
Show resolved
Hide resolved
marioevz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, at the moment it needs a rebase and some lint fixes.
You can run:
uvx --with=tox-uv tox -e static
to help you get them sorted out.
Removed skip markers from checklist template tests.
Add TEMPLATE_PATH for accessing checklist templates.
Removed unused TEMPLATE_PATH definition from test file.
2822288 to
b8f2174
Compare
I have applied all the requested changes and the branch has been successfully rebased and I also checked the static checks locally and they passed. thanks for the guidance!! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/osaka #1740 +/- ##
============================================
Coverage 86.08% 86.08%
============================================
Files 743 743
Lines 44072 44072
Branches 3891 3891
============================================
Hits 37938 37938
Misses 5656 5656
Partials 478 478
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🗒️ Description
This PR addresses Issue #1645 by re-enabling two sets of EEST unit tests that were previously disabled due to the missing docs subtree dependency.
To ensure the re-enabled tests run correctly after the repository refactoring, the file path constant pointing to the documentation template (TEMPLATE_PATH) was corrected to use an 8-level directory traversal in the following files:
packages/testing/.../test_checklist_template_consistency.py
packages/testing/.../eip_checklist.py
All re-enabled tests pass successfully on the latest build.
🔗 Related Issues or PRs
Fixes #1645
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.