Skip to content

Conversation

@Praniti1594
Copy link
Contributor

@Praniti1594 Praniti1594 commented Nov 3, 2025

🗒️ Description

This PR addresses Issue #1645 by re-enabling two sets of EEST unit tests that were previously disabled due to the missing docs subtree dependency.

To ensure the re-enabled tests run correctly after the repository refactoring, the file path constant pointing to the documentation template (TEMPLATE_PATH) was corrected to use an 8-level directory traversal in the following files:

packages/testing/.../test_checklist_template_consistency.py

packages/testing/.../eip_checklist.py

All re-enabled tests pass successfully on the latest build.

🔗 Related Issues or PRs

Fixes #1645

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

chetna-mittal pushed a commit to gnosischain/execution-specs that referenced this pull request Nov 8, 2025
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, at the moment it needs a rebase and some lint fixes.

You can run:

uvx --with=tox-uv tox -e static

to help you get them sorted out.

@Praniti1594
Copy link
Contributor Author

LGTM, at the moment it needs a rebase and some lint fixes.

You can run:

uvx --with=tox-uv tox -e static

to help you get them sorted out.

I have applied all the requested changes and the branch has been successfully rebased and I also checked the static checks locally and they passed. thanks for the guidance!!

@spencer-tb spencer-tb added C-chore Category: chore A-test-tools Area: execution spec tests tooling labels Nov 24, 2025
@spencer-tb spencer-tb changed the title Fix/issue 1654 chore(test-tools): re-enable eip checklist docs unit tests Nov 24, 2025
@spencer-tb spencer-tb merged commit e3f36eb into ethereum:forks/osaka Nov 24, 2025
12 checks passed
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.08%. Comparing base (705739a) to head (b8f2174).
⚠️ Report is 15 commits behind head on forks/osaka.

Additional details and impacted files
@@             Coverage Diff              @@
##           forks/osaka    #1740   +/-   ##
============================================
  Coverage        86.08%   86.08%           
============================================
  Files              743      743           
  Lines            44072    44072           
  Branches          3891     3891           
============================================
  Hits             37938    37938           
  Misses            5656     5656           
  Partials           478      478           
Flag Coverage Δ
unittests 86.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-tools Area: execution spec tests tooling C-chore Category: chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-enable EEST unit tests after docs subtree is added

4 participants