Skip to content

Conversation

@kclowes
Copy link
Contributor

@kclowes kclowes commented Nov 19, 2025

πŸ—’οΈ Description

πŸ”— Related Issues or PRs

N/A.

βœ… Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2025

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 79.17%. Comparing base (a26f1a4) to head (c0713cd).

Additional details and impacted files
@@               Coverage Diff               @@
##           forks/osaka    #1801      +/-   ##
===============================================
- Coverage        86.08%   79.17%   -6.91%     
===============================================
  Files              743      743              
  Lines            44072    44072              
  Branches          3891     3891              
===============================================
- Hits             37938    34895    -3043     
- Misses            5656     8239    +2583     
- Partials           478      938     +460     
Flag Coverage Ξ”
unittests 79.17% <ΓΈ> (-6.91%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SamWilsn
Copy link
Contributor

Is the coverage drop here expected (~7%)?

@kclowes
Copy link
Contributor Author

kclowes commented Nov 19, 2025

Is the coverage drop here expected (~7%)?

Is not. Thank you for flagging!

@kclowes
Copy link
Contributor Author

kclowes commented Nov 19, 2025

@SamWilsn can you whitelist actions/cache? I ran into an error when I tried to cache the DB: [Error](https://github.com/ethereum/execution-specs/actions/runs/19487658812/workflow) The action actions/cache@v4 is not allowed in ethereum/execution-specs because all actions must be from a repository owned by ethereum or match one of the patterns: JamesIves/github-pages-deploy-action@*, actions-rs/toolchain@*, actions/cache/restore@*, actions/checkout@*, actions/deploy-pages@*, actions/download-artifact@*, actions/github-script@*, actions/setup-go@*, actions/setup-python@*, actions/upload-artifact@*, actions/upload-pages-artifact@*, astral-sh/setup-uv@*, codecov/codecov-action@*, davidanson/markdownlint-cli2-action@*, jwlawson/actions-setup-cmake@*, softprops/action-gh-release@*. All actions must also be pinned to a full-length commit SHA.

@SamWilsn
Copy link
Contributor

Done!

@kclowes
Copy link
Contributor Author

kclowes commented Nov 21, 2025

This was a failed experiment :( going to try something else!

@kclowes kclowes closed this Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants