Skip to content

Conversation

@felix314159
Copy link
Contributor

🗒️ Description

With this PR a logged line from our custom logging plugin appears as e.g.:
2025-11-20 13:53:22 [INFO] ./tests/frontier/opcodes/test_dup.py:60: hello
Before it would vaguely describe the name of the pytest plugin (still visible now when errors occur in what pytest prints) and you still would not know in which file and which line things happened.

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@felix314159
Copy link
Contributor Author

@danceratopz Is hive log parse unrelated to this? There seems to exist a very specific unit test that expects logging in some exact way

@marioevz marioevz merged commit fa1a2bb into ethereum:forks/osaka Nov 22, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants