feat(spec,test): EIP-7708 spec updates for self as target

[fselmo]

🗒️ Description

SELFDESTRUCT

• Tracking the discussion here that selfdestruct logs may only be emitted if created and destroyed in same tx (EIP-6780)
  • EIP update: Update EIP-7708: clarify order of burn logs and coinbase transfer logs EIPs#11190

CALL and Transactions

• Exclude logs for transfer of value to self:
  • CALL EIP update: Update EIP-7708: Clarify CALL to self does not emit transfer log EIPs#11187
  • Transaction EIP update: Update EIP-7708: Clarify transaction transfer to different account EIPs#11188

Also added some more test cases for coverage emitting transfer logs when not in the same tx, self destruct logs when in same tx, combo of transfer and selfdestruct logs across fork transition, update tests to reflect above changes

closes #2088

✅ Checklist

• All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:

  uvx tox -e static

• All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
• All: Considered updating the online docs in the ./docs/ directory.
• All: Set appropriate labels for the changes (only maintainers can apply labels).
• Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
• Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
• Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.14%. Comparing base (bf16746) to head (41d9159).
⚠️ Report is 23 commits behind head on eips/amsterdam/eip-7708.

Additional details and impacted files

@@                     Coverage Diff                     @@
##           eips/amsterdam/eip-7708    #2086      +/-   ##
===========================================================
- Coverage                    86.14%   84.14%   -2.01%     
===========================================================
  Files                          599      642      +43     
  Lines                        39491    42267    +2776     
  Branches                      3782     4066     +284     
===========================================================
+ Hits                         34021    35566    +1545     
- Misses                        4848     5971    +1123     
- Partials                       622      730     +108     

Flag	Coverage Δ
unittests	84.14% <100.00%> (-2.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[jochem-brouwer]

Checked tests, they look good but left a few nit comments and commented on one test where I think it is not tested what is intended.

Here are some extra cases to add:

• Ensure CALLCODE does not emit any logs
• Ensure SELFDESTRUCT to COINBASE emits the correct logs
  This specific case will: 1. Invoke selfdestruct (address is coinbase), this could burn eth if coinbase has funds already (the contract created is thus sending to Op.ADDRESS, but the block.coinbase is set such that this matches the created address). 2. Pay the priority fees to coinbase and 3. Destroy coinbase.
• Ensure that in all 3 create situations (tx create, CREATE, CREATE2) the logs are emitted correctly
• Invoking selfdestruct in the same contract multiple times (parametrize sending to self (burn), other addresses, and then burn again). This should either burn or emit transfer logs.
• Send via selfdestruct funds to a contract already marked for selfdestruct.
• Ensure that a transaction which 7702-delegates an account, which calls that account, which itself does SELFDESTRUCT, does not do the burn logs (as it does not burn since contract is not created)
• Ensure that if any action done in current tx, which reverts, that the logs are also deleted

Let me know if I can assist 😄 👍

[fselmo]

Here are some extra cases to add:

This is quite helpful, thank you 👍🏼. Imo, we should track these cases in the tracker for this EIP here. Or feel free to push here if you have permissions or PR to this branch. My goal here is to update the spec and provide enough tests to get a new release out and get clients to agree. Anything beyond this I think we can make subsequent PRs with more test cases. Wdyt?

Let me know if I can assist 😄 👍

The more the merrier 🙂! Thank you for the review! I will look into updating this tomorrow. Much appreciated 🙏🏼

[marioevz]

Some comments, thanks!

[marioevz]

Thanks for these tests! And many thanks to @jochem-brouwer for your review!

I think we can go ahead and merge as-is, and add any remaining tests to the tracker #1875, in order to (a) be able to release soon, and (b) keep this PR from growing out of proportion.

[fselmo]

add any remaining tests to the tracker

done #1875 (comment) 👍🏼