feat(spec,test): Update EIP-7708 coinbase expectation based on latest spec

[fselmo]

🗒️ Description

Recent spec changes were updated to emit finalization LOG2 after EIP-1559 fees are paid to coinbase.

This PR corrects the spec and adds a correctly failing test before this spec change and passes with the spec change. Tests that when the self-destructing (in same tx) address is also the coinbase, it receives the fees from the sender before the log and thus the log amount contains these fees. We have two test cases:

• Funded before finalization:
  • coinbase is created, funded (LOG3), and destroyed in same tx (LOG2 shows all eth is burned)
  • coinbase receives miner fees from sender
  • checks finalization LOG2 with exactly the miner fees as its amount.
• Only miner fees:
  • coinbase is created, funded (LOG3) and destroyed in same tx (LOG2 shows all eth is burned)
  • coinbase is funded by an outside account self-destructing to it (LOG3)
  • coinbase receives miner fees from sender
  • checks finalization LOG2 with exactly the funded amount + miner fees as its amount.

🔗 Related Issues or PRs

• Update to EIP-7708: Update EIP-7708: clarify order of burn logs and coinbase transfer logs EIPs#11190

✅ Checklist

• All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:

  uvx tox -e static

• All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
• All: Considered updating the online docs in the ./docs/ directory.
• All: Set appropriate labels for the changes (only maintainers can apply labels).
• Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
• Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.

Cute Animal Picture

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.14%. Comparing base (bf16746) to head (f6dd830).
⚠️ Report is 24 commits behind head on eips/amsterdam/eip-7708.

Additional details and impacted files

@@                     Coverage Diff                     @@
##           eips/amsterdam/eip-7708    #2106      +/-   ##
===========================================================
- Coverage                    86.14%   84.14%   -2.01%     
===========================================================
  Files                          599      642      +43     
  Lines                        39491    42267    +2776     
  Branches                      3782     4066     +284     
===========================================================
+ Hits                         34021    35566    +1545     
- Misses                        4848     5971    +1123     
- Partials                       622      730     +108     

Flag	Coverage Δ
unittests	84.14% <100.00%> (-2.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Carsons-Eels]

I think this looks great, my only suggestion would be to add a test which validates that the amount in the finalization log includes the priority fee calculation. I don't see that as a reason to block this merge though

[Carsons-Eels]

Suggested change

	# deletion AFTER miner fee transfer.
	# deletion AFTER miner fee transfer. (EIPs#11190 clarification)

[fselmo]

my only suggestion would be to add a test which validates that the amount in the finalization log includes the priority fee calculation.

The finalization balance is included in the log that's checked in the expected receipt. Both tests have this check, one for priority fee by itself (not funded after ETH burn) and one for priority fee + funded amount 👌🏼.