feat(validate): new validate command for direct client binary testing#2622
Draft
spencer-tb wants to merge 1 commit intoethereum:forks/amsterdamfrom
Draft
feat(validate): new validate command for direct client binary testing#2622spencer-tb wants to merge 1 commit intoethereum:forks/amsterdamfrom
spencer-tb wants to merge 1 commit intoethereum:forks/amsterdamfrom
Conversation
d67f961 to
8e48ce6
Compare
2c76c12 to
2658023
Compare
New `validate` CLI command for running EEST fixtures directly against client EVM binaries, replacing Hive for execution correctness testing. Usage: validate health # health check all clients validate engine --client geth # engine tests validate state --client besu # state tests validate block --client nethermind # block tests Features: - 7 clients: geth, besu, nethermind, erigon, reth, ethrex, nimbus - Per-type Pydantic result models: StateTestResult, BlockTestResult, EngineTestResult with type-specific fields - Exception matching: maps client error strings to EEST exception types via ExceptionMapper, verifies correct exception for every invalid test (--no-exception-check to disable) - Cross-validation: lastBlockHash against fixture, lastPayloadStatus (VALID/INVALID) for engine tests - validate.toml config for client binary paths with per-type overrides (state-bin, block-bin, engine-bin) - Auto bin-workers and xdist tuning per client - Bundled Frontier sanity fixtures for health checks - Shared validate_helpers.py for validation logic Client binary PRs: - geth: ethereum/go-ethereum#34650 - erigon: erigontech/erigon#20315 - besu: besu-eth/besu#10184 - nethermind: NethermindEth/nethermind#11035 - reth: paradigmxyz/reth#23361 - ethrex: lambdaclass/ethrex#6445 - nimbus: status-im/nimbus-eth1#4101 - revm: bluealloy/revm#3544 Tracking issue: ethereum#2319
2658023 to
88d72b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
New
validate(props to @raxhvl for the naming convention) CLI command for running EEST fixtures directly against client EVM binaries. Replacesconsume directwith a cleaner UX — type is the subcommand,--clientis required, no--binor--typeflags.Features
StateTestResult(stateRoot),BlockTestResult(lastBlockHash),EngineTestResult(lastPayloadStatus)--no-exception-checkto disable)go-ethereumresolves togethconsume direct: replaced entirely byvalidatePydantic Result Models
All client adapters return structured results via a shared model hierarchy in
cli_types.py:FixtureTestResultname,pass,fork,errorStateTestResultstateRootvalidate stateBlockTestResultlastBlockHashvalidate blockEngineTestResultlastBlockHash,lastPayloadStatusvalidate engineEach client binary outputs JSON matching these schemas. The shared
validate_helpers.pymodule validates results against fixture expectations:postStatehashlastblockhashExceptionMapperagainst fixture'sexpectException/validationErrorResults (v5.3.0 fixtures, Apple M-series)
Exception check = client reports validation error on pass for negative tests, enabling EELS-side exception verification.
Client PRs (adding statetest/blocktest/enginetest runners)
🔗 Related Issues or PRs
Fixes #2319
✅ Checklist
just statictype(scope):.