feat(tests): enhance test coverage, add mainnet test for eip-2780 - #3266
Open
LouisTsai-Csie wants to merge 1 commit into
Open
feat(tests): enhance test coverage, add mainnet test for eip-2780#3266LouisTsai-Csie wants to merge 1 commit into
LouisTsai-Csie wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3266 +/- ##
================================================
Coverage 93.42% 93.42%
================================================
Files 625 625
Lines 37032 37032
Branches 3385 3385
================================================
Hits 34597 34597
Misses 1666 1666
Partials 769 769
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add more EIP-2780 test coverage, and mainnet test cases.
New coverage:
test_intrinsic_charges_authority_in_access_listtest_self_transfer_with_delegated_sendertest_intrinsic_decomposition_across_tx_typesThe mainnet test cases are duplicated as tests already in this directory, and
cover less than the originals do:
test_eip_mainnet.pytest_transaction_gas, all 10test_value_moving_transactions, all 10test_contract_creation_gas, bothtest_value_contract_creation_tx[success-*]init_revertstest_authorization_gas[existing_authority]test_single_authorization_charges[sets_new_delegation],test_account_write_first_write_of_authority[existing_eoa]test_authorization_gas[new_authority]test_single_authorization_charges[creates_account],test_account_write_first_write_of_authority[non_existent]I am consider removing
test_eip_mainnet.pyand marking those existing tests with themainnetmarker instead.Related Issues or PRs
issue #1940, #3217
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture