core,miner,params: implement EIP-7934 - RLP Execution Block Size Limit #31990
+54
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwasinger
requested review from
fjl,
karalabe,
gballet,
rjl493456442,
zsfelfoldi and
MariusVanDerWijden
as code owners
fjl
reviewed
Jun 9, 2025
miner/worker.go
Outdated
| @@ -391,6 +394,10 @@ func (miner *Miner) commitTransactions(env *environment, plainTxs, blobTxs *tran | |||
| continue | |||
| } | |||
|
|
|||
| if miner.chainConfig.IsOsaka(env.header.Number, env.header.Time) && env.size+tx.Size() > params.BlockRLPSizeCap { | |||
There was a problem hiding this comment.
Also, the block body size is also influenced by other things, such as withdrawals. So we need to add a bit of buffer into the size limit here. For the withdrawals, we may be able to add their true size into env.size before adding transactions.
| work.size += params.WithdrawalSize | ||
| } | ||
| } else { | ||
| includedWithdrawals = genParam.withdrawals |
There was a problem hiding this comment.
We need to confirm that including a part of withdrawals specified by the CL is OK at the consensus level.
…if we would hit the size cap when filling it with txs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.