eth/catalyst: add initial OpenTelemetry tracing for newPayload#33521
Merged
fjl merged 21 commits intoethereum:masterfrom Feb 17, 2026
Merged
eth/catalyst: add initial OpenTelemetry tracing for newPayload#33521fjl merged 21 commits intoethereum:masterfrom
fjl merged 21 commits intoethereum:masterfrom
Conversation
1895a15 to
ffe8de3
Compare
This was referenced Jan 5, 2026
bff3829 to
4b13763
Compare
jrhea
commented
Jan 14, 2026
8bf89c7 to
2c270e2
Compare
ce41bcc to
5731ca5
Compare
9c009cb to
0d2fc33
Compare
MariusVanDerWijden
previously approved these changes
Jan 23, 2026
core/state_processor.go
Outdated
Comment on lines
119
to
134
Member
There was a problem hiding this comment.
Can we also get a span for the post-block system calls?
Contributor
Author
There was a problem hiding this comment.
Do you want a span for each one? Would any specific attributes be helpful?
Contributor
There was a problem hiding this comment.
It's OK to have a span for all of them at once. In order to make this work, we should move the system calling into its own method and start a span at top, then end it with defer.
fjl
reviewed
Feb 3, 2026
75aa685 to
65b6b78
Compare
84960cb to
65b6b78
Compare
f6bd3f7 to
fee1233
Compare
Refactor error handling and request initialization in postExecution.
jwasinger
reviewed
Feb 17, 2026
core/state_processor.go
Outdated
| var requests [][]byte | ||
| if config.IsPrague(block.Number(), block.Time()) { | ||
| requests = [][]byte{} | ||
| var requests [][]byte |
Contributor
There was a problem hiding this comment.
@fjl This is the line that breaks blockchain tests. For some reason, it is expected to return a non-nil requests list post-prague if there are no requests.
Seems to do with the hash of a nil requests not matching that of an empty one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds initial OpenTelemetry tracing to the Engine API, focusing on engine_newPayload*.