cmd/geth: add Prague pruning points#33657
Conversation
|
Any particular reason for choosing Cancun? Why not Osaka? |
|
My thinking was to keep at least a year of history and Cancun was the one that met the criteria. I am open to adding Prague and Osaka as options. |
|
Triage discussion: update prune point to Pectra |
s1na
changed the title
| return errors.New("--history.chain flag is required (use 'postmerge' or 'postprague')") | ||
| } | ||
| var mode history.HistoryMode | ||
| if err := mode.UnmarshalText([]byte(ctx.String(utils.ChainHistoryFlag.Name))); err != nil { |
There was a problem hiding this comment.
it's a bit weird to convert the string to []byte, and then convert it back to string in the function. Better change the function interface.
There was a problem hiding this comment.
hm i see what you mean. just a note that this function wasn't implemented as part of this PR. I believe the goal was to stick to the idiomatic UnmarshalText signature that is widely used.
There was a problem hiding this comment.
with golang, "idiomatic" often turns into "idiotic". ok, won't die on that hill.
4 participants
This PR allows users to prune their nodes up to the Prague fork. It indirectly depends on #32157 and can't really be merged before eraE files are widely available for download.
The
--history.chainflag becomes mandatory forprune-historycommand. Here I've listed all the edge cases that can happen and how we behave:prune-history Behavior
Node Startup Behavior