trie/bintrie: fix debug_executionWitness for binary tree#33739
Merged
s1na merged 1 commit intoethereum:masterfrom Feb 3, 2026
Merged
trie/bintrie: fix debug_executionWitness for binary tree#33739s1na merged 1 commit intoethereum:masterfrom
s1na merged 1 commit intoethereum:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Witnessmethod was not implemented for the binary tree, which causeddebug_excutionWitnessto panic. This PR fixes that.Note that the
TransitionTrieversion isn't implemented, and that's on purpose: more thought must be given to what should go in the global witness. But the PSE people are waiting on this fix and they don't need the transition, so I'd rather merge this first and handle the transition version when it's thought-through.