crypto/ecies: fix panic on short ciphertext in symDecrypt#33753
Closed
BZO95 wants to merge 1 commit intoethereum:masterfrom
Closed
crypto/ecies: fix panic on short ciphertext in symDecrypt#33753BZO95 wants to merge 1 commit intoethereum:masterfrom
BZO95 wants to merge 1 commit intoethereum:masterfrom
Conversation
Contributor
Author
|
flaky test |
Contributor
|
Is this condition still reachable? We recently extended a bounds check earlier in Decrypt that should prevent this from triggering. This fix looks good to me, and I'd merge it regardless, just trying to assess whether this is actually possible. |
Contributor
Author
|
@fjl Thanks for the review! I added it for defense-in-depth since this handles untrusted crypto input. The check is cheap and makes preconditions explicit, but happy to remove if you prefer. |
Member
|
It's a private function and is only invoked by the Decrypt. We have the validation performed there and the input is regarded as trusted. |
Contributor
Author
|
@rjl493456442 Got it, closing this PR since the check isn't needed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds length check before slicing ciphertext in symDecrypt, prevents panic when ct is shorter than block size.