eth/filters: rangeLogs should error on invalid block range#33763
Merged
s1na merged 2 commits intoethereum:masterfrom Mar 18, 2026
Merged
eth/filters: rangeLogs should error on invalid block range#33763s1na merged 2 commits intoethereum:masterfrom
s1na merged 2 commits intoethereum:masterfrom
Conversation
rjl493456442
previously approved these changes
Feb 6, 2026
Contributor
Author
|
Greeting! is this good to process? cc @rjl493456442 and @s1na |
Contributor
|
@vickkkkkyy tests are failing, please fix |
Contributor
Author
fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into this while testing a monitoring script - passed fromBlock=100, toBlock=50 by mistake and got back an empty array. Took me way too long to figure out it was just my params being backwards lol.
Turns out updateChainView in the same file already returns errInvalidBlockRange for this case, so just making rangeLogs do the same thing.