all: devnet 3 by jwasinger · Pull Request #33930 · ethereum/go-ethereum

jwasinger · 2026-03-02T23:27:04Z

Contains changes required for devnet 3. The BAL changes are in a branch here and build on several open PRs:

Other EIPs in devnet 3 with open PRs have been squashed into single commits and included on this branch:

EIPs missing from this branch:

EIP-8159: eth/71 - Block Access List Exchange (no implementation of it yet)

jwasinger · 2026-03-03T04:25:42Z

There's some new failing spec tests introduced in the 7928 changes. I am looking into them.

jwasinger · 2026-03-03T20:51:01Z

There's currently a lot of tests failing. Likely, some the failures are related to 8037, but I have yet to deep dive into them.

healthykim · 2026-03-04T09:46:49Z

eth70 is ready to be merged :)

jwasinger · 2026-03-05T01:45:06Z

I rebased this because 7778 was merged. I also merged the eth 70 changes in here.

jwasinger · 2026-03-05T02:18:58Z

@MariusVanDerWijden I stripped the outdated 8037 changes from this branch.

core/vm/gascosts.go

jwasinger · 2026-03-11T20:48:53Z

core/vm/gas_table.go

@@ -391,97 +421,155 @@ func gasCall(evm *EVM, contract *Contract, stack *Stack, mem *Memory, memorySize
 	} else if !evm.StateDB.Exist(address) {
 		gas += params.CallNewAccountGas


If we are post-amsterdam, we need to exclude this from the regular gas. I am attempting to integrate #33648 in to this branch, which should make this change.

core/vm/operations_acl.go

jwasinger · 2026-03-16T21:46:55Z

core/state_transition.go

+			prev := st.gasRemaining.RegularGas
+			// When the calldata floor exceeds actual gas used, any
+			// remaining state gas must also be consumed
+			targetRemaining := (st.initialGas.RegularGas + st.initialGas.StateGas) - floorDataGas


can we get into a situation where targetRemaining > params.MaxTxGasLimit? If the tx gas limit is high, and the gas used low, the state gas might be vastly larger than floorDataGas.

CopyHeader copies all pointer-typed header fields (WithdrawalsHash, RequestsHash, SlotNumber, etc.) but was missing the deep copy for BlockAccessListHash added by EIP-7928. This caused the BAL hash to be silently shared between the original and the copy, leading to potential data races and incorrect nil-checks on copied headers.

Adds support for returning `blockAccessListHash` in the RPC block header response. This change includes `blockAccessListHash` in `RPCMarshalHeader` when `head.BlockAccessListHash` is not nil, aligning the RPC output with the Header struct which already contains this field.

* add method on StateReaderTracker to clear the accumulated reads * don't factor the BAL size into the payload size during construction in the miner * simplify miner code for constructing payloads-with-BALs via the use of aformentioned StateReaderTracker clear method * clean up the configuration of the BAL execution mode based on the preset flag specified

## Summary - The BAL refactoring in 5808d21 removed the line `env.header.GasUsed = env.gasPool.Used()` from `applyTransaction()`, causing all geth-proposed blocks to have `GasUsed=0` in the header - Every other client rejects these blocks during validation, so geth can never successfully propose on the network - Restores the single line that was present in upstream master ## Test plan - [x] Verified line exists in upstream/master at miner/worker.go:409 - [x] Confirmed all 34 geth-proposed blocks on a 4-client devnet had `GasUsed=0` via `debug_getBadBlocks` on besu - [ ] Build local image and verify geth proposals are accepted in a multi-client Kurtosis network

…ly read doesn't appear in both the read/write set in the BAL Co-authored-by: MariusVanDerWijden <m.vanderwijden@live.de>

…ss list hash on block header when calling 'Block.WithAccessList'

… made some changes to the --bal.executionmode flag

Rename `balHash` to `blockAccessListHash` in json encoding of block header. Fix miner panic when attempting to create pre-amsterdam blocks.

jwasinger · 2026-04-01T17:28:38Z

@MariusVanDerWijden I pushed a fix to an issue found by @qu0b . PTAL at 566992d and if it looks okay to you, we can add it to the 8037 branch.

jwasinger · 2026-04-01T17:47:51Z

Oops. Those fixes broke some tests. Reverted them until I can get them working

Co-authored-by: jwasinger <j-wasinger@hotmail.com>

…with access lists Co-authored-by: spencer <spencer.tb@ethereum.org>

To check whether a transaction can be applied, we validate that `blockGasLimit > txGasLimit + (cumulativeRegularGasUsed + cumulativeStateGasUsed)`. However, the check should only be applied to the bottleneck resource, i.e. `blockGasLimit > max(txRegularGasUsed+cumulativeRegularGasUsed, txStateGasUsed+ cumulativeStateGasUsed)`. The changes here break multiple tests. I am trying to determine why. --------- Co-authored-by: qu0b <stefan@starflinger.eu>

…mapper

The BAL reader tracker captures access list reads at the reader level. When statedb has an account cached the BAL tracker is not informed of the access. This is ok during the lifetime of a transaction because you only need to record the access the first time. It is also ok during the lifetime of a block because BAL reads are block-level (same as statedb caches). Where I think the issue can rise is in the miner. Namely when building a block, if the miner picks up a tx which fails, it drops it and picks up another tx to include. There might be some edge case here where the failed tx which is not included poisons the cache and a future block which is included omits an account because it wasn't aware of the access.

Fixes the collision bugs and create gas ordering

jwasinger force-pushed the bal-devnet-3 branch from 44ac067 to 9c834c4 Compare March 3, 2026 21:13

jwasinger force-pushed the bal-devnet-3 branch from c7caff4 to 830d381 Compare March 5, 2026 01:08

jwasinger force-pushed the bal-devnet-3 branch from cb10e9c to 9fdd74b Compare March 5, 2026 02:17

techdoutdigi21 approved these changes Mar 6, 2026

View reviewed changes

jwasinger commented Mar 8, 2026

View reviewed changes

core/vm/gascosts.go Outdated Show resolved Hide resolved

jwasinger commented Mar 11, 2026

View reviewed changes

fjl added the amsterdam label Mar 12, 2026

MariusVanDerWijden force-pushed the bal-devnet-3 branch from a247ae0 to e1521be Compare March 12, 2026 14:29

jwasinger commented Mar 16, 2026

View reviewed changes

core/vm/operations_acl.go Show resolved Hide resolved

jwasinger commented Mar 16, 2026

View reviewed changes

MariusVanDerWijden force-pushed the bal-devnet-3 branch from e5d453c to b3113ba Compare March 24, 2026 08:52

MariusVanDerWijden and others added 14 commits March 31, 2026 16:59

core: implement EIP-8037: state creation gas cost increase

40f34ee

all: implement eip 7928 block access lists

265d74b

update test fixtures to devnet 3. fix build

2135705

fix some lint errors (TODO: merge this commit into the 7928 changes

6d1df21

address more lint errors

787464a

eth/catalyst: propagate passed context in call to newPayload

bbde08c

core: fix storage deletion

c7ab998

core: fix deadlock in parallel state processor

98f757b

all: fix rebasing issues

18848bc

all: fix rebasing issues

8327e87

jwasinger and others added 4 commits March 31, 2026 17:56

core/types/bal: ensure that a written storage slot which was previous…

2ff40c7

…ly read doesn't appear in both the read/write set in the BAL Co-authored-by: MariusVanDerWijden <m.vanderwijden@live.de>

core/types: don't include BAL in rlp encoding of full block. Set acce…

e4f8478

…ss list hash on block header when calling 'Block.WithAccessList'

fix stale generated file that I forgot to include with recent PR that…

c339f4e

… made some changes to the --bal.executionmode flag

Some fixes for bal-devnet-3 (#34090)

53719ad

Rename `balHash` to `blockAccessListHash` in json encoding of block header. Fix miner panic when attempting to create pre-amsterdam blocks.

jwasinger force-pushed the bal-devnet-3 branch from 0253db6 to 53719ad Compare March 31, 2026 23:04

jwasinger force-pushed the bal-devnet-3 branch from 191ae16 to 53719ad Compare April 1, 2026 17:47

jwasinger and others added 15 commits April 2, 2026 14:20

update to eest bal 5.6.0 release

6cc0be1

core/state: various fixes in EIP-7928 (#34641)

c3ad754

Co-authored-by: jwasinger <j-wasinger@hotmail.com>

core: perform BAL validation against gas limit for blocks which come …

710ffb0

…with access lists Co-authored-by: spencer <spencer.tb@ethereum.org>

core: preface invalid bal errors so they are caught by the exception …

6a79e36

…mapper

core/types: fix merging state mutations (EIP-7928) (#34640)

6009625

core: fix tx-inclusion tests

3e37ed1

core/vm: easier logic

0578ebb

core: introduce vm.GasBudget

7783267

core/vm: fix gas usage

ce91d22

core: fix rebasing issue

fa79954

core/vm: fix two bugs

cd2095f

Fixes the collision bugs and create gas ordering

build: update BAL tests

33c9201

core: fix 8037 transaction inclusion

189bbd9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

all: devnet 3#33930

all: devnet 3#33930
jwasinger wants to merge 33 commits intomasterfrom
bal-devnet-3

jwasinger commented Mar 2, 2026 •

edited

Loading

Uh oh!

jwasinger commented Mar 3, 2026

Uh oh!

jwasinger commented Mar 3, 2026 •

edited

Loading

Uh oh!

healthykim commented Mar 4, 2026

Uh oh!

jwasinger commented Mar 5, 2026 •

edited

Loading

Uh oh!

jwasinger commented Mar 5, 2026

Uh oh!

Uh oh!

jwasinger Mar 11, 2026

Uh oh!

Uh oh!

jwasinger Mar 16, 2026

Uh oh!

jwasinger commented Apr 1, 2026

Uh oh!

jwasinger commented Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

		@@ -391,97 +421,155 @@ func gasCall(evm EVM, contract Contract, stack Stack, mem Memory, memorySize
		} else if !evm.StateDB.Exist(address) {
		gas += params.CallNewAccountGas

Conversation

jwasinger commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jwasinger commented Mar 3, 2026

Uh oh!

jwasinger commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

healthykim commented Mar 4, 2026

Uh oh!

jwasinger commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jwasinger commented Mar 5, 2026

Uh oh!

Uh oh!

jwasinger Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jwasinger Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

jwasinger commented Apr 1, 2026

Uh oh!

jwasinger commented Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

jwasinger commented Mar 2, 2026 •

edited

Loading

jwasinger commented Mar 3, 2026 •

edited

Loading

jwasinger commented Mar 5, 2026 •

edited

Loading