cmd/geth: cover attach header flag order in test#34111
Open
0xWeakSheep wants to merge 1 commit intoethereum:masterfrom
Open
cmd/geth: cover attach header flag order in test#341110xWeakSheep wants to merge 1 commit intoethereum:masterfrom
0xWeakSheep wants to merge 1 commit intoethereum:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates
TestAttachWithHeadersto cover both accepted flag orders for custom RPC headers ingeth attach:geth attach -H "first: one" -H "second: two" <endpoint>geth -H "first: one" -H "second: two" attach <endpoint>The previous test only executed the first form and kept the second as a commented follow-up note. This change turns the second form into an active assertion.
Why
This makes the expected CLI behavior explicit and protected by test coverage, so future flag parsing changes won't regress either invocation style.
Testing
go test ./cmd/geth -run TestAttachWithHeaders -count=1