graphql: expose all sync progress fields in schema#34112
Open
0xWeakSheep wants to merge 1 commit intoethereum:masterfrom
Open
graphql: expose all sync progress fields in schema#341120xWeakSheep wants to merge 1 commit intoethereum:masterfrom
0xWeakSheep wants to merge 1 commit intoethereum:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a schema/resolver mismatch for GraphQL
SyncState.graphql.SyncStateresolver already exposes the full sync progress surface, butgraphql/schema.goonly declared:startingBlockcurrentBlockhighestBlockAs a result, several implemented sync progress fields were not queryable through GraphQL.
This change adds the missing fields to the GraphQL schema:
syncedAccountssyncedAccountBytessyncedBytecodessyncedBytecodeBytessyncedStoragesyncedStorageByteshealedTrienodeshealedTrienodeByteshealedBytecodeshealedBytecodeByteshealingTrienodeshealingBytecodetxIndexFinishedBlockstxIndexRemainingBlocksstateIndexRemainingTests
Added
TestSyncStateSchemaFieldsingraphql/graphql_test.go.The test runs a GraphQL introspection query on
SyncStateand asserts all expected field names are present, preventing future schema drift.Why
Without these schema entries, clients cannot access resolver fields that are already implemented and documented by the syncing resolver comments.