metrics, metrics/prometheus: fix histogram count and sum to be cumulative#34658
Open
knQzx wants to merge 1 commit intoethereum:masterfrom
Open
metrics, metrics/prometheus: fix histogram count and sum to be cumulative#34658knQzx wants to merge 1 commit intoethereum:masterfrom
knQzx wants to merge 1 commit intoethereum:masterfrom
Conversation
resetting timers and resetting samples now track cumulative count and sum across snapshots so that prometheus _count and _sum metrics monotonically increase as required by the prometheus spec. the per-window values and percentiles still reset normally.
knQzx
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_countand_sumvalues for prometheus histograms usingResettingSampleandResettingTimerwere resetting on every scrape instead of being monotonically increasingrate(),increase(), and average latency calculations in prometheus/grafanaWhat changed
resetting_timer.go: addedtotalCount/totalSumfields that accumulate across snapshots, exposed viaTotalCount()/TotalSum()resetting_sample.go: added cumulative count/sum tracking with mutex, snapshot now returns cumulative valuesprometheus/collector.go: switched toTotalCount()for the prometheus_countmetricTest plan
Count()for non-prometheus consumers (influxdb, exp) unchangedfixes #34628