core/filtermaps: fix snapshot data sharing and optimize row mapping cache#34661
Closed
MiraWells wants to merge 1 commit intoethereum:masterfrom
Closed
core/filtermaps: fix snapshot data sharing and optimize row mapping cache#34661MiraWells wants to merge 1 commit intoethereum:masterfrom
MiraWells wants to merge 1 commit intoethereum:masterfrom
Conversation
…ache Clone blockLvPtrs in makeSnapshot to prevent shared slice mutation. Reuse BasicLRU on mapRenderer struct instead of allocating a new mutex-protected Cache per map, reducing GC pressure and eliminating unnecessary synchronization overhead.
Author
|
Closing this PR. The crash was root-caused to a known Go 1.26.0/1.26.1 runtime bug on Windows (golang/go#77975), not a code issue in filtermaps. The fix is in the Go release-branch.go1.26 and will ship with Go 1.26.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clone blockLvPtrs in makeSnapshot to prevent shared slice mutation.
Reuse BasicLRU on mapRenderer struct instead of allocating a new
mutex-protected Cache per map, reducing GC pressure and eliminating
unnecessary synchronization overhead.
These changes address a fatal crash (
unexpected fault address/signal 0xc0000005) observed during concurrent state snapshotgeneration and filter map tail indexing on large datasets (~37 GiB).