eth/filters: use typed error for range limit exceeded#34674
Open
Kubudak90 wants to merge 1 commit intoethereum:masterfrom
Open
eth/filters: use typed error for range limit exceeded#34674Kubudak90 wants to merge 1 commit intoethereum:masterfrom
Kubudak90 wants to merge 1 commit intoethereum:masterfrom
Conversation
Replace fmt.Errorf with errRangeLimitExceeded to ensure proper error detection via IsRangeLimitExceeded function. The typed error implements the rpc.Error interface with correct error code (-32602). Fixes ethereum#1234
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an inconsistency in error handling where was used instead of the typed error.
Problem
In , when the block range exceeds the configured limit, the code was returning:
However, the file defines a proper typed error that:
Solution
Replace the call with the typed error:
Benefits
Testing
The change is minimal and maintains the same error message format. Existing tests for range limit handling should continue to pass.