Skip to content

log: share mutex in log handles with same writer and other fields #35074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fjl merged 1 commit into from
Jun 10, 2026
Merged

log: share mutex in log handles with same writer and other fields #35074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion log/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ func (h *discardHandler) WithAttrs(attrs []slog.Attr) slog.Handler {
}

type TerminalHandler struct {
mu sync.Mutex
mu *sync.Mutex
wr io.Writer
lvl slog.Level
useColor bool
Expand Down Expand Up @@ -66,6 +66,7 @@ func NewTerminalHandler(wr io.Writer, useColor bool) *TerminalHandler {
// records which are less than or equal to the specified verbosity level.
func NewTerminalHandlerWithLevel(wr io.Writer, lvl slog.Level, useColor bool) *TerminalHandler {
return &TerminalHandler{
mu: &sync.Mutex{},
wr: wr,
lvl: lvl,
useColor: useColor,
Expand All @@ -92,6 +93,7 @@ func (h *TerminalHandler) WithGroup(name string) slog.Handler {

func (h *TerminalHandler) WithAttrs(attrs []slog.Attr) slog.Handler {
return &TerminalHandler{
mu: h.mu,
wr: h.wr,
lvl: h.lvl,
useColor: h.useColor,
Expand Down
Loading