eth/protocols/snap: don't ignore batch write error in resetSyncState - #35521
Open
0xSHKWON wants to merge 2 commits into
Open
eth/protocols/snap: don't ignore batch write error in resetSyncState#355210xSHKWON wants to merge 2 commits into
0xSHKWON wants to merge 2 commits into
Conversation
| deleteRange(batch, rawdb.SnapshotStoragePrefix) | ||
| s.resetTrienodes(batch) | ||
| batch.Write() | ||
| if err := batch.Write(); err != nil { |
Member
There was a problem hiding this comment.
Please return the error instead of panicing here.
0xSHKWON
force-pushed
the
snap-reset-sync-state-write-error
branch
from
August 24, 2026 11:53
29ce01e to
e6cee39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The final
batch.WriteinresetSyncStateis the only unchecked batch write in this file; if it fails, the in-memory state is reinitialized as a fresh sync while the stale flat state remains on disk, silently corrupting the regenerated state.