eth, blobpool: reconcile cell fetching after custody updates - #35541
Open
reddaisyy wants to merge 1 commit into
Open
eth, blobpool: reconcile cell fetching after custody updates#35541reddaisyy wants to merge 1 commit into
reddaisyy wants to merge 1 commit into
Conversation
Signed-off-by: reddaisyy <reddaisy@outlook.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
engine_forkchoiceUpdatedV4forwards every non-nilcustodyColumnsupdate to
BlobFetcher.UpdateCustody:However, the fetcher loop currently only replaces the bitmap:
This makes new announcements observe the new custody set, but it does not reconcile queued, in-flight, or already pooled partial blob transactions whose state was created under the previous custody set.
EIP-8070 is currently in Review. Its Engine API specification requires:
The specification permits, but does not require, already queued sampling requests to be patched.
Reconcile sparse blob cell fetching when the custody set changes.
Previously,
BlobFetcher.UpdateCustodyonly replaced the current custody bitmap. Existing partial fetches and transactions already stored in the blobpool were not updated to fetch newly required columns. Completion also required exact equality between fetched and custody indices, so a custody contraction could leave a fetch incomplete when extra cells had already been received.This change:
Tests
Added regression coverage for: