core/txpool/blobpool: speed up serving pre eth/72 peers - #35543
Merged
Conversation
cskiraly
force-pushed
the
sparseblobs-fast-path
branch
2 times, most recently
from
August 18, 2026 04:49
4f20f38 to
756d516
Compare
Serving a blob tx to a legacy (pre eth/72) peer re-reads it from disk and
re-encodes its full blobs on every GetPooledTransactions request, even though
the same transaction is typically requested by multiple peers. The fast path
removed the KZG cost, but the disk read and blob re-encode remain, and the KZG
cost would return for non-data custody.
Memoize the encoded wire response in a byte-bounded (16 MiB) LRU keyed by
(tx hash, whether full blobs are needed). The encoding is content-addressed and
stable while a tx is pooled, so a hit is served only after confirming the tx is
still present (a dropped tx must not be resurrected from the cache). eth/72+
requests (blob payload elided) are cached separately from legacy full-blob ones.
Adds blobpool/getrlp/{hit,miss} meters.
Requests for transactions the pool does not hold were marked as cache misses, conflating 'not cached' with 'not ours' and skewing the hit ratio the meter exists to expose. Mark a miss only once the transaction is known to be pooled and about to be encoded.
cskiraly
force-pushed
the
sparseblobs-fast-path
branch
from
August 19, 2026 13:31
756d516 to
a5fe5ac
Compare
rjl493456442
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add cache for recovered cells.
Serving a blob tx to a legacy (pre eth/72) peer re-reads it from disk and
re-encodes its full blobs on every GetPooledTransactions request, even though
the same transaction is typically requested by multiple peers. The fast path
removed the KZG cost, but the disk read and blob re-encode would remain without
this. Enhance, a dedicated cache is added for this purpose.