Skip to content

eth: return iterator errors from debug_storageRangeAt #35554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghwo336 wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −0
Open

eth: return iterator errors from debug_storageRangeAt #35554

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions eth/api_debug.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,13 @@ func storageRangeAt(statedb *state.StateDB, root common.Hash, address common.Add
next := common.BytesToHash(it.Key)
result.NextKey = &next
}
// Iterator.Next returns false on both exhaustion and error, so a failure to
// resolve a trie node mid-range would otherwise be reported as a complete
// result (a nil NextKey claims all keys were returned). Surface the error
// instead of silently truncating.
if it.Err != nil {
return StorageRangeResult{}, it.Err
}
return result, nil
}

Expand Down
Loading