eth/downloader: switch to full sync when progressing past genesis (fixes #28222) - #35567
Open
SakeyJakey wants to merge 1 commit into
Open
eth/downloader: switch to full sync when progressing past genesis (fixes #28222)#35567SakeyJakey wants to merge 1 commit into
SakeyJakey wants to merge 1 commit into
Conversation
| // If we're in snap sync mode, check if the chain has progressed past genesis | ||
| // and has state available. If so, snap sync is complete and we can switch to full sync. | ||
| if m.mode == ethconfig.SnapSync { | ||
| head := m.chain.CurrentBlock() |
Member
There was a problem hiding this comment.
This logic has been applied in the syncModer constructor. I don't get why we need to duplicate this logic here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before when Geth starts on a network at the genesis block using the default sync mode,
syncModer.get()returned SnapSync whenever the mode was SnapSync which meant the node would always be stuck inSnapSyncmode even after the chain advanced and local state was made for the next blocks.This fixes the issue by checking if local state is available for blocks past genesis when checking the node's sync mode.
I also made a unit test to make sure this works.
fixes #28222