-
Notifications
You must be signed in to change notification settings - Fork 63
Optimize memory representation and operations #707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks! I am looking at it. Only changing the concrete one is definitely OK. I'm trying to see what's the deal with the Symbolic. Feels like it'd be nice to unify the two, like you did. |
OK, I had a look. Either way
Will get executed. But with your system, we first execute
which is basically another copyslice. So I'd rather keep the concrete and the symbolic separate. Otherwise, it looks cool! |
This might be desirable to keep Concrete turned Symbolic memories small
Hey! If you could remove that tunable then I think we could just merge :) Would be nice! |
Thanks, this is great! Can you please add a CHANGELOG element? Then I think we can merge :) |
Thanks! I squash-merged, so it's a single commit. I hope that's OK! |
Description
An Echidna user reported continuously increasing memory while running mstore/mcopy operations. This PR attempts to resolve that by
Checklist