simulators/ethereum/sync: reduce finalized block distance to zero #1367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgimenez
approved these changes
Oct 29, 2025
Collaborator
|
Thanks for the comment. I added the finalized distance as an experiment because there were some issues. I'm curious to hear why you say the client only syncs to the finalized block? Why does it not sync to the head block? |
fjl
changed the title
Collaborator
|
Still curious why it only syncs to the finalized block and not head. |
yep, this was a problem on our side, live sync was not triggered after backfill was completed, fixed by paradigmxyz/reth#19390 we were not aware of this issue because of the regular FCUs from the CL in normal operation, the test helped to find the issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
ethereum/synctest waits for the other peer to sync to head block.However, the other peer only syncs to latest finalized block.
This test will therefore never pass if the latest finalized block is not the head block.
This was not a problem until this commit 8d692b4 introduced a finalized distance of fifty.
Hence, the solution is to reduce the finalized distance to zero.
This change matches the original behavior of the test before it started failing for most of the clients.