Skip to content

Upgrade py-ecc past a buggy release, to 1.4.6 #1576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 13, 2018
Merged

Upgrade py-ecc past a buggy release, to 1.4.6 #1576

merged 3 commits into from
Dec 13, 2018

Conversation

carver
Copy link
Contributor

@carver carver commented Dec 11, 2018

What was wrong?

py-ecc was pinned to an old version to resolve a bug.

How was it fixed?

Upgrade py-ecc past the buggy release.

Cute Animal Picture

put a cute animal picture link inside the parentheses

@carver
Copy link
Contributor Author

carver commented Dec 11, 2018

Looks like some flake8 errors made it into master. I'll go through all the other PRs/Issues before trying to fix it here.

@veox
Copy link
Contributor

veox commented Dec 12, 2018

Experiencing same lint CI run failure as here ATM in PR #1579.

(Subscribing myself so I get to see how to fix it.)

@pipermerriam
Copy link
Member

Not flake8. It is the new release of py_ecc which now exposes it's type hints, and thus, our type checks are now mad about a few things.

@cburgdorf
Copy link
Contributor

which now exposes it's type hints

PEP561 at work, beautiful

@hwwhww
Copy link
Contributor

hwwhww commented Dec 12, 2018

@carver @pipermerriam
Fix py_ecc: ethereum/py_ecc#40
py-evm side: hwwhww@a326a0e

  • A few FQP_point_to_FQ2_point transformation, not a perfect solution here...
    On the other hand, I'm not sure if we should make it looser by just making all FQ2 and FQ12 type hinting to FQP. Might need to think about it more after or during Library refactor py_ecc#31.

  • Also will need another py_ecc version bump + update py-evm requires.

EDIT: Since there's no type hinting for bls12-381, some error won't be shown after #1581 is merged. That also needs to be figured out after bls12-381 has type hinting.

@pipermerriam
Copy link
Member

@hwwhww I bumped py_ecc here in the PR

@hwwhww
Copy link
Contributor

hwwhww commented Dec 12, 2018

@pipermerriam thank you! 👍

@carver hwwhww/py-evm@a326a0e passed the CI: https://circleci.com/gh/hwwhww/py-evm/tree/pr1576

@carver carver merged commit be5cb8c into master Dec 13, 2018
@carver carver deleted the py-ecc-upgrade branch December 13, 2018 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants