Skip to content

minor docstring fixups #5938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

minor docstring fixups #5938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
adcf1ef
Update dgit_github.test.ts
zeroprooff Apr 6, 2025
bdbd2af
Update dgit_local.test.ts
zeroprooff Apr 6, 2025
8ef8eb6
Update erc721.test.ts
zeroprooff Apr 6, 2025
cfa877c
Update generalSettings.test.ts
zeroprooff Apr 6, 2025
fb4318d
Update homeTab.test.ts
zeroprooff Apr 6, 2025
7fbbb26
Update importFromGithub.test.ts
zeroprooff Apr 6, 2025
ebddd7b
Update proxy_oz_v4.test.ts
zeroprooff Apr 6, 2025
2078446
Update proxy_oz_v5.test.ts
zeroprooff Apr 6, 2025
d582f83
Update proxy_oz_v5_non_shanghai_runtime.test.ts
zeroprooff Apr 6, 2025
f6a4243
Update signingMessage.test.ts
zeroprooff Apr 6, 2025
aef6823
Update generalSettings.test.ts
zeroprooff Apr 16, 2025
c775be8
Update dgit_github.test.ts
zeroprooff Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/remix-ide-e2e/src/tests/dgit_github.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ module.exports = {
'login to github #group1 #group2': function (browser: NightwatchBrowser) {
browser
.waitForElementVisible('*[data-id="github-panel"]')
.waitForElementVisible('*[data-id="gitubUsername"]')
.waitForElementVisible('*[data-id="githubUsername"]')
.setValue('*[data-id="githubToken"]', process.env.dgit_token)
.pause(1000)
.setValue('*[data-id="gitubUsername"]', 'git')
.setValue('*[data-id="githubUsername"]', 'git')
.pause(1000)
.setValue('*[data-id="githubEmail"]', '[email protected]')
.pause(1000)
Expand Down Expand Up @@ -376,7 +376,7 @@ module.exports = {
.pause(1000)
.setValue('*[data-id="githubToken"]', 'invalidtoken')
.pause(1000)
.setValue('*[data-id="gitubUsername"]', 'git')
.setValue('*[data-id="githubUsername"]', 'git')
.pause(1000)
.setValue('*[data-id="githubEmail"]', '[email protected]')
.pause(1000)
Expand Down
6 changes: 3 additions & 3 deletions apps/remix-ide-e2e/src/tests/dgit_local.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ module.exports = {
.waitForElementVisible('*[data-id="github-panel"]')
.pause(1000)
.click('*[data-id="github-panel"]')
.waitForElementVisible('*[data-id="gitubUsername"]')
.setValue('*[data-id="gitubUsername"]', 'git')
.waitForElementVisible('*[data-id="githubUsername"]')
.setValue('*[data-id="githubUsername"]', 'git')
.setValue('*[data-id="githubEmail"]', '[email protected]')
.click('*[data-id="saveGitHubCredentials"]')
.modalFooterOKClick('github-credentials-error')
Expand Down Expand Up @@ -634,4 +634,4 @@ async function spawnGitServer(path: string): Promise<ChildProcess> {
} catch (e) {
console.log(e)
}
}
}
2 changes: 1 addition & 1 deletion apps/remix-ide-e2e/src/tests/erc721.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ module.exports = {
.waitForElementVisible('*[data-id="treeViewLitreeViewItemcontracts"]')
.waitForElementVisible('*[data-id="treeViewLitreeViewItemcontracts/MyToken.sol"]')
.openFile('contracts/MyToken.sol')
// because the compilatiom imports are slow and sometimes stop loading (not sure why, it's bug) we need to recompile and check to see if the files are really in de FS
// because the compilation imports are slow and sometimes stop loading (not sure why, it's bug) we need to recompile and check to see if the files are really in de FS
.clickLaunchIcon('solidity')
.pause(2000)
.click('[data-id="compilerContainerCompileBtn"]')
Expand Down
14 changes: 7 additions & 7 deletions apps/remix-ide-e2e/src/tests/generalSettings.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,12 @@ module.exports = {
browser.waitForElementVisible('*[data-id="verticalIconsKindsettings"]', 5000)
.scrollAndClick('*[data-id="settingsTabThemeLabelCerulean"]')
.pause(5000)
.checkElementStyle(':root', '--primary', remixIdeThemes.curelean.primary)
.checkElementStyle(':root', '--secondary', remixIdeThemes.curelean.secondary)
.checkElementStyle(':root', '--success', remixIdeThemes.curelean.success)
.checkElementStyle(':root', '--info', remixIdeThemes.curelean.info)
.checkElementStyle(':root', '--warning', remixIdeThemes.curelean.warning)
.checkElementStyle(':root', '--danger', remixIdeThemes.curelean.danger)
.checkElementStyle(':root', '--primary', remixIdeThemes.cerulean.primary)
.checkElementStyle(':root', '--secondary', remixIdeThemes.cerulean.secondary)
.checkElementStyle(':root', '--success', remixIdeThemes.cerulean.success)
.checkElementStyle(':root', '--info', remixIdeThemes.cerulean.info)
.checkElementStyle(':root', '--warning', remixIdeThemes.cerulean.warning)
.checkElementStyle(':root', '--danger', remixIdeThemes.cerulean.danger)
},

'Should load Flatly theme ': function (browser: NightwatchBrowser) {
Expand Down Expand Up @@ -177,7 +177,7 @@ const remixIdeThemes = {
warning: '#c97539',
danger: '#b84040'
},
curelean: {
cerulean: {
primary: '#2FA4E7',
secondary: '#e9ecef',
success: '#73A839',
Expand Down
2 changes: 1 addition & 1 deletion apps/remix-ide-e2e/src/tests/homeTab.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ module.exports = {
.waitForElementVisible('*[data-id="homeTabGetStartedremixDefault"]')
.click('*[data-id="homeTabGetStartedremixDefault"]')
.waitForElementVisible('*[data-id="treeViewDivtreeViewItemcontracts/1_Storage.sol"]')
.waitForElementVisible('*[data-id="treeViewLitreeViewItemcontracts/2_Owner.sol"')
.waitForElementVisible('*[data-id="treeViewLitreeViewItemcontracts/2_Owner.sol"]')
.waitForElementVisible('*[data-id="treeViewDivDraggableItemREADME.txt"')
.click('*[data-id="treeViewDivtreeViewItemcontracts/1_Storage.sol"]')
.waitForElementPresent({
Expand Down
2 changes: 1 addition & 1 deletion apps/remix-ide-e2e/src/tests/importFromGithub.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ module.exports = {
browser
.click('div[data-id="verticalIconsHomeIcon"]')
.openFile('package.json')
.waitForElementVisible("*[data-path='git-hometab-test.git/package.json'")
.waitForElementVisible("*[data-path='git-hometab-test.git/package.json']")
.getEditorValue((content) => {
browser.assert.ok(content.indexOf('"name": "remix-project",') !== -1, 'content does contain "name": "remix-project"')
})
Expand Down
4 changes: 2 additions & 2 deletions apps/remix-ide-e2e/src/tests/proxy_oz_v4.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ module.exports = {
return sources
},

'Should set the compiler version to 8.19': function(browser: NightwatchBrowser) {
'Should set the compiler version to v0.8.19': function(browser: NightwatchBrowser) {
browser.setSolidityCompilerVersion('soljson-v0.8.19+commit.7dd6d404.js')
},

Expand Down Expand Up @@ -342,4 +342,4 @@ const sources = [
`
}
}
]
]
4 changes: 2 additions & 2 deletions apps/remix-ide-e2e/src/tests/proxy_oz_v5.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ module.exports = {
.addFile('myTokenV1.sol', sources[0]['myTokenV1.sol'])
.clickLaunchIcon('solidity')
.pause(2000)
// because the compilatiom imports are slow and sometimes stop loading (not sure why, it's bug) we need to recompile and check to see if the files are really in de FS
// because the compilation imports are slow and sometimes stop loading (not sure why, it's bug) we need to recompile and check to see if the files are really in de FS
.click('[data-id="compilerContainerCompileBtn"]')
.clickLaunchIcon('filePanel')
.isVisible({
Expand Down Expand Up @@ -344,4 +344,4 @@ const sources = [
`
}
}
]
]
4 changes: 2 additions & 2 deletions apps/remix-ide-e2e/src/tests/proxy_oz_v5_non_shanghai_runtime.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ module.exports = {
.addFile('myTokenV1.sol', sources[0]['myTokenV1.sol'])
.clickLaunchIcon('solidity')
.pause(2000)
// because the compilatiom imports are slow and sometimes stop loading (not sure why, it's bug) we need to recompile and check to see if the files are really in de FS
// because the compilation imports are slow and sometimes stop loading (not sure why, it's bug) we need to recompile and check to see if the files are really in de FS
.click('[data-id="compilerContainerCompileBtn"]')
.clickLaunchIcon('filePanel')
.isVisible({
Expand Down Expand Up @@ -350,4 +350,4 @@ const sources = [
`
}
}
]
]
4 changes: 2 additions & 2 deletions apps/remix-ide-e2e/src/tests/signingMessage.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ module.exports = {
// we check here that the input is strictly "test message"
browser.assert.equal(signature.value, '0xaa8873317ebf3f34fbcc0eab3e9808d851352674c28a3d6b88dc84db6e10fc183a45bcec983a105964a13b54f18e43eceae29d982bf379826fb7ecfe0d42c6ba1b', 'signature should be tied to the input "test message"')
})
.addFile('signMassage.sol', sources[0]['signMassage.sol'])
.openFile('signMassage.sol')
.addFile('signMessage.sol', sources[0]['signMessage.sol'])
.openFile('signMessage.sol')
.clickLaunchIcon('solidity')
.click('*[data-id="compilerContainerCompileBtn"]')
.clickLaunchIcon('udapp')
Expand Down