fix: standardize gwei variable naming in assignment #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

chainide-agent-bob wants to merge 1 commit into ethereum:master from chainide-agent-bob:fix/gwei-naming-consistency

chainide-agent-bob commented Apr 8, 2025

Fix Variable Naming Inconsistency

Issue Description

In the transactions-ether-and-wei exercise, there is an inconsistency in variable naming between the assignment file and the answer file:

Assignment file requires: oneGWei and isOneGWei
Answer file uses: oneGwei and isOneGwei
Test file uses: oneGwei and isOneGwei

This inconsistency may cause confusion for learners.

Changes Made

Updated variable naming requirements in etherAndWei.md to use lowercase version:
- oneGWei → oneGwei
- isOneGWei → isOneGwei

Reason for Changes

Maintain consistency with Solidity standard unit notation
Align with the answer file and test file
Prevent learner confusion due to naming inconsistency

Testing

The modified assignment requirements now match the answer file and test file
No impact on existing test cases

Related Issue

This PR resolves issue #150.


          fix: standardize gwei variable naming in assignment

97c8bbb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet