Separate type class registration pass in experimental analysis #14558
Conversation
| private: | ||
| friend class TypeEnvironment; | ||
|
|
||
| TypeClassInfo const& typeClassInfo(TypeClass _class) const | ||
| { | ||
| return m_typeClasses.at(_class.m_index); | ||
| } |
There was a problem hiding this comment.
Not sure why this was private in the first place. I need to access it to get at the type variable after the class is already registered. Is there some other way I am supposed to get it?
| struct GlobalAnnotation | ||
| { | ||
| }; |
There was a problem hiding this comment.
Perhaps I should move more things from TypeInference here? builtinClasses and builtinClassesByName looks like good candidates.
I tried that already with typeClassFunctions but the problem is that I don't have the function types to put in it - those are only available after TypeInference processes function definitions. I could just gather FunctionDefinitions but TypeInference would have to iterate over them again and it did not seem like it would save us much code.
cameel
force-pushed
the
new-analysis-type-class-registration-pass
branch
from
2746135 to
98269f3
Compare
|
soltest was failing due to the missing |
nikola-matic
force-pushed
the
newAnalysis
branch
2 times, most recently
from
b2363a8 to
acad00f
Compare
cameel
force-pushed
the
new-analysis-type-class-registration-pass
branch
from
98269f3 to
da83b35
Compare
…tration-pass Separate type class registration pass in experimental analysis
…tration-pass Separate type class registration pass in experimental analysis
…tration-pass Separate type class registration pass in experimental analysis
…tration-pass Separate type class registration pass in experimental analysis
…tration-pass Separate type class registration pass in experimental analysis
…tration-pass Separate type class registration pass in experimental analysis
…tration-pass Separate type class registration pass in experimental analysis
…tration-pass Separate type class registration pass in experimental analysis
Base PR: #14510.