Constant evaluator support for member constants #16056
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusaaguiar
force-pushed
the
constantEvaluatorSupportForMemberAccess
branch
2 times, most recently
from
93d7f5a to
78e1d3e
Compare
matheusaaguiar
force-pushed
the
constantEvaluatorSupportForMemberAccess
branch
from
1e7955b to
985b03f
Compare
clonker
reviewed
May 22, 2025
test/libsolidity/syntaxTests/constantEvaluator/member_access.sol
Outdated
Show resolved
Hide resolved
matheusaaguiar
force-pushed
the
constantEvaluatorSupportForMemberAccess
branch
from
ad3f23a to
7fa4363
Compare
clonker
reviewed
May 23, 2025
| @@ -407,3 +409,24 @@ void ConstantEvaluator::endVisit(TupleExpression const& _tuple) | |||
| if (!_tuple.isInlineArray() && _tuple.components().size() == 1) | |||
| m_values[&_tuple] = evaluate(*_tuple.components().front()); | |||
| } | |||
|
|
|||
| void ConstantEvaluator::endVisit(MemberAccess const& _memberAcess) | |||
There was a problem hiding this comment.
Sorry I just see this now, there's a typo here...
Suggested change
| void ConstantEvaluator::endVisit(MemberAccess const& _memberAcess) | |
| void ConstantEvaluator::endVisit(MemberAccess const& _memberAccess) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16055.