Skip to content

refactor: remove unsupported bridge modes #1758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025

Conversation

KolbyML
Copy link
Member

@KolbyML KolbyML commented Apr 14, 2025

What was wrong?

We no longer want to support

  • the old history bridge which used a JSON-RPC provider
  • the ERA1 bridge as it requires downloading separate accumulators and we are replacing it with the E2HS bridge which allows for a simpler bridge to be built, with better UX, and supports bridging the full block range instead of only pre-merge.

How was it fixed?

  • I removed all the unsupported code
  • I changed the get_header() rpc to get_block() as it will be used in the new ephemeral bridge

To-Do's I will do in followup PR's

  • remove the use of the trace_gossip, remove the trace_gossip RPC, and instead use direct offers and a census
  • make E2HS bridge pull from http endpoint instead of local directory.
  • implement the ephemeral bridge
  • build a script to generate a new E2HS file once the blocks are finalized, to keep our http E2HS endpoint up to date

ogy is finishing the deneb proofs and validation, I am going to finish generating all the E2HS files

Notes

All of our History Bridge infrastructure is off right now, I will update the clusters configurations and re-enable it with the E2HS bridge after make E2HS bridge pull from http endpoint instead of local directory is done. Which should be done tomorrow, as paul said he would setup the endpoint tomorrow and most of the work is already done.

@KolbyML KolbyML requested review from ogenev and morph-dev April 14, 2025 21:01
@KolbyML KolbyML self-assigned this Apr 14, 2025
@KolbyML KolbyML force-pushed the delete-old-bridge branch 2 times, most recently from 91d2060 to c3e9645 Compare April 14, 2025 21:22
@KolbyML KolbyML force-pushed the delete-old-bridge branch from c3e9645 to 6483aea Compare April 14, 2025 21:23
Copy link
Collaborator

@morph-dev morph-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More of a rubber stamp, as it's mostly code removal.

🚀

.into_transactions()
.map(|transaction| transaction.into_inner())
.collect(),
ommers: vec![],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't block contain ommers (in case of a pre-merge)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made it so the function will return an error if it is a pre-merge block, since we have no reason for this code to request pre-merge blocks as we should use ERA1 or E2HS

@KolbyML KolbyML merged commit 73b9526 into ethereum:master Apr 15, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants