Conversation
|
@morph-dev please look at my review of the previous PR here, #1763 (comment) is generating invalid execution headers |
Yes, that's what I was planning on doing. However, requests inside BeaconBlockBody are grouped by type, and I'm not sure in which order they should be iterated for execution header. I assume it would be "deposit requests" then "withdrawals requests" then "consolidations requests", but I'm not 100% sure. Will look into it tomorrow... |
Here is how it is performed in the consensus-spec https://github.com/ethereum/consensus-specs/blob/dev/specs/electra/beacon-chain.md#new-get_execution_requests_list |
|
Thanks for the info! Done. |
KolbyML
left a comment
There was a problem hiding this comment.
I haven't verified if ForkName::Electra => [0xad, 0x53, 0x2c, 0xeb] is correct but other then that the PR looks good
![]()
What was wrong?
We don't have any Pectra types defined.
How was it fixed?
I rebased #1763 and added few more things on top (rebase is first commit, mine is second):
Planned work for the followup PRs:
HeaderWithProofbased on Pectra typesTo-Do