feat!: client_info string doesn't need to decode #1896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morph-dev
force-pushed
the
client_info
branch
from
8a570bc to
3a4b06c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Decoding/deserializing
ClientInfoRadiusCapabilitieswould fail whenclient_infofield is set but not in the exact format as expected. This field is not mandatory and rarely important, while other fields are, so failing decoding entire object is wrong.How was it fixed?
Change the type of the field to
Stringand provide ways to parse it, either in failing way (returning error if format is not exactly as expected) or best effort (always succeeds, but some fields could be set to the wrong value).