Skip to content

Conversation

@SunnysidedJ
Copy link

This PR adds unified metrics across different ELs for the new GetBlobsV2 Engine API that is WIP in PR #3976.

Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @SunnysidedJ! thanks for your contribution 🙏 ❤️

@holgerd77
Copy link
Member

Cool 🙏 🤩, have directly taken this as an occasion to consolidate and update our dev docs, so that you (and follow-up contributors) can get some better orientation on tooling, see here #4079 until merged! 🙂

@SunnysidedJ
Copy link
Author

Sure, no problem. Thank you for responsive review and updates @g11tech and @holgerd77 !

@codecov
Copy link

codecov bot commented May 14, 2025

Codecov Report

Attention: Patch coverage is 70.31250% with 38 lines in your changes missing coverage. Please review.

Project coverage is 84.78%. Comparing base (0303764) to head (8af7e55).

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 84.33% <ø> (ø)
blockchain ?
client ?
common 97.51% <100.00%> (+<0.01%) ⬆️
devp2p ?
evm 73.11% <100.00%> (ø)
mpt 89.74% <ø> (+0.30%) ⬆️
statemanager ?
static 99.11% <ø> (ø)
tx 89.83% <87.20%> (-0.06%) ⬇️
util 88.63% <24.24%> (-0.57%) ⬇️
vm 55.53% <75.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@acolytec3 acolytec3 force-pushed the getblobsv2-metrics branch 2 times, most recently from 4e3f469 to 8af7e55 Compare May 16, 2025 19:45
@g11tech g11tech force-pushed the peerdas branch 2 times, most recently from 1b56516 to 25cceeb Compare May 29, 2025 07:39
@acolytec3 acolytec3 deleted the branch ethereumjs:peerdas May 29, 2025 10:02
@acolytec3 acolytec3 closed this May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants