Skip to content

RPC: Ping extension support#743

Merged
acolytec3 merged 16 commits intomasterfrom
ping-RPC
Mar 20, 2025
Merged

RPC: Ping extension support#743
acolytec3 merged 16 commits intomasterfrom
ping-RPC

Conversation

@ScottyPoi
Copy link
Copy Markdown
Collaborator

@ScottyPoi ScottyPoi commented Feb 28, 2025

Implements changes in (WIP) https://github.com/ethereum/portal-network-specs/pull/369/files

  • Adds helper method ultralight_getPingPayload
    • Params: NetworkId, Extension Type
    • Returns: Ping extension payload
    • Updates portal_*Ping with ping extension support

Comment thread packages/cli/src/rpc/modules/portal.ts Outdated
Copy link
Copy Markdown
Collaborator

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acolytec3 acolytec3 marked this pull request as ready for review March 20, 2025 17:40
@acolytec3 acolytec3 merged commit 7453209 into master Mar 20, 2025
4 checks passed
@acolytec3 acolytec3 deleted the ping-RPC branch March 20, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants