Instant WDs stEth #294
Open
Instant WDs stEth #294
+2,247
−170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivam-ef
requested changes
Sep 23, 2025
- Add feeShareToStakers parameter to _processStETHRedemption - Call burnEEthShares to distribute fees to stakers in stETH flow - Update share validation to account for both withdrawal and fee burning - Ensure consistent fee handling between ETH and stETH redemption flows - Add InvalidOutputToken error for unsupported output tokens - Improve function documentation and parameter naming
…on-staker-fees fix: add fee split to stETH redemption flow
…h-fixes Vaibhav/instant wd steth fixes
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sherlock AI FindingsThe automated tool completed its analysis of the codebase and found no potential security issues. Next Steps: No immediate actions are required. Continue monitoring the codebase with future scans. Full report available at: https://ai.sherlock.xyz/runs/9cd08762-8c98-4116-8d39-affd959206d9 |
- Added `deploy.s.sol` to handle the deployment of EtherFi contracts including `EtherFiRedemptionManagerTemp`, `EtherFiRestaker`, `EtherFiRedemptionManager`, and `LiquidityPool`. - Created utility functions in `utils.sol` for deployment and verification processes.
- Introduced `transactions.s.sol` for managing upgrade and rollback processes for EtherFi contracts. - Removed unused variables and comments from `deploy.s.sol`. - Added a new `readme.md` to document deployment and upgrade procedures. - Updated utility functions in `utils.sol` to include minimum delay constants for timelocks.
…tions - Updated `transactions.s.sol` to include new contract implementations for `EtherFiRedemptionManager`, `EtherFiRedemptionManagerTemp`, `EtherFiRestaker`, and `LiquidityPool`. - Enhanced utility functions in `utils.sol` to support proxy upgradeability checks and time calculations.
- Enhanced `scheduleCleanUpStorageOnEFRM` and `_clearOutSlotForUpgrade` functions to utilize operation IDs for better transaction tracking. - Implemented `initializeTokenParametersEFRM` function to set token parameters for `EtherFiRedemptionManager`.
- Implemented `verifyCreate2Address` function to compute the predicted address for contracts created with Create2, enhancing deployment verification capabilities. - Refactored `getImplementation` function to streamline proxy implementation retrieval using `vm.load`.
…on handling in stETH withdrawal script
- Introduced `VerifyStETHWithdrawals` contract to validate addresses, bytecode, upgradeability, and new functionality for EtherFi contracts.
…EtherFiRedemptionManagerTemp`, `EtherFiRestaker`, and `LiquidityPool
…y-verify-instant_wdrls_for_stETH Implement deployment and verifications scripts for stETH withdrawals upgrade
| function redeemEEthWithPermit(uint256 eEthAmount, address receiver, IeETH.PermitInput calldata permit, address outputToken) external whenNotPaused nonReentrant { | ||
| try eEth.permit(msg.sender, address(this), permit.value, permit.deadline, permit.v, permit.r, permit.s) {} catch {} | ||
| _redeemEEth(eEthAmount, receiver); | ||
| _redeemEEth(eEthAmount, receiver, outputToken); |
There was a problem hiding this comment.
Bug: Permit Signature Failure Due to Incorrect Owner
The permit calls within redeemEEthWithPermit and redeemWeEthWithPermit incorrectly use msg.sender as the owner. This causes permit signatures to be invalid, leading to failed redemptions when the receiver differs from msg.sender.
Additional Locations (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Enable instant redemptions to ETH or stETH with per-token limits/fees, updating RedemptionManager, LiquidityPool, and Restaker, plus upgrade tooling and tests.
src/EtherFiRedemptionManager.sol: Add support to redeem toETHorstETHviaoutputToken; introduce per-tokenRedemptionInfomapping,initializeTokenParameters, and token-scoped admin setters; update rate-limit/low-watermark logic per token; extend events/errors; integrateEtherFiRestaker/Lido; modify redeem/permit functions to includeoutputToken.src/LiquidityPool.sol: AddburnEEthSharesForNonETHWithdrawal(_amountSharesToBurn, _withdrawalValueInETH)and event; adjust accounting for non-ETH withdrawals.src/EtherFiRestaker.sol: AddetherFiRedemptionManagerref andtransferStETH(recipient, amount)(restricted to RedemptionManager).src/EtherFiRedemptionManagerTemp.sol: Temporary impl to clear storage slots during upgrade.src/interfaces/ILiquidityPool.sol: Expose newburnEEthSharesForNonETHWithdrawal.script/stETH-withdrawals/{deploy,transactions,verify}.s.solandscript/utils/utils.solfor CREATE2 deploy, upgrade/rollback scheduling, and verification.script/ContractCodeChecker.solbyte-compare order.EtherFiRedemptionManager,EtherFiRedemptionManagerTemp,EtherFiRestaker; updatedLiquidityPoolsalt/address.Written by Cursor Bugbot for commit 4645215. This will update automatically on new commits. Configure here.