feat(crypto): Bound Signatures #5082
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjmelements
commented
Dec 20, 2025
wjmelements
commented
Dec 20, 2025
| const sig = Signature.from(signature); | ||
|
|
||
| let secpSig = secp256k1.Signature.fromCompact(getBytesCopy(concat([ sig.r, sig.s ]))); | ||
| let secpSig = secp256k1.Signature.fromCompact(getBytesCopy(concat([ sig.r, sig._s ]))); |
Author
There was a problem hiding this comment.
Without this change, recoverAddress fails with TypeError: non-canonical s; use ._s. I don't think recoverAddress should assert the signature has low-S ("canonical", EIP-2), because that restriction only applies to transaction signatures. recoverAddress should also succeed for non-canonical signatures.
An alternative fix would be to have Signature.from make the signature canonical, but this change makes more sense to me.
Author
|
@ricmoo this is ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer @ricmoo
This adds support for ERC-8111 (Bound Signatures).
Bound signatures provide a good compression mechanism for signatures because the compressed form can be passed directly to ecrecover without transformation.
They utilize signature malleability to eliminate v.
Consumers of bound signatures would expect a specific
v(usually 27).See EIP-2.
Test Plan
npm exec mocha --trace-warnings --reporter ./reporter.cjs ./lib.esm/_tests/test-crypto.jsChanges