Wallet factory upgrade and redeploy contracts

[cryptonoyaiba]

Description

• Updated wallet factory and redeployment

Motivation and Context

• Updated wallet factory
• Requires redeploy of contracts

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Summary by CodeRabbit

• Documentation

  • Refreshed contract addresses table: removed outdated entries and added updated addresses, including a new HookMultiPlexer entry; updated ModularEtherspotWallet, ModularEtherspotWalletFactory, Bootstrap, and MultipleOwnerECDSAValidator.

• Chores

  • Added deployment/run artifacts (transactions, receipts, metadata) for multiple networks (1, 10, 100, 10200, 11155111, 11155420, 114) to support verification and auditing, including post-deploy stake setup.

[coderabbitai]

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

💤 Files selected but had no reviewable changes (2)

• script/NonDeterministicDeployAllAndSetup.s.sol
• test/harnesses/CredibleAccountModuleHarness.sol

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Adds broadcast artifacts documenting deployments across multiple chains and updates README contract addresses. New deployment JSONs include CREATE2 deployments for ModularEtherspotWallet, ModularEtherspotWalletFactory, Bootstrap, MultipleOwnerECDSAValidator, HookMultiPlexer, plus an addStake call. README updates the contract addresses table to include HookMultiPlexer.

Changes

Cohort / File(s)	Summary
README addresses README.md	Replaced several contract address rows and added a HookMultiPlexer entry in the contracts table.
Broadcast artifacts — chain 1 broadcast/DeployAllAndSetup.s.sol/1/run-1748432402.json, broadcast/DeployAllAndSetup.s.sol/1/run-latest.json	Added full deployment/run logs with multiple CREATE2 deployments and a final addStake CALL; includes receipts, logs, and metadata.
Broadcast artifacts — chain 10 broadcast/DeployAllAndSetup.s.sol/10/run-1748443142.json, broadcast/DeployAllAndSetup.s.sol/10/run-latest.json	Added deployment traces mirroring chain 1: CREATE2 deployments and addStake CALL with receipts and metadata.
Broadcast artifacts — chain 100 broadcast/DeployAllAndSetup.s.sol/100/run-1748428685.json, broadcast/DeployAllAndSetup.s.sol/100/run-latest.json	Introduced deployment logs with CREATE2 deployments and addStake CALL; includes receipts and commit/timestamp metadata.
Broadcast artifacts — chain 10200 broadcast/DeployAllAndSetup.s.sol/10200/run-1746573005.json, broadcast/DeployAllAndSetup.s.sol/10200/run-latest.json	Added deployment and receipt data for CREATE2 deployments plus addStake CALL; no source-code changes.
Broadcast artifacts — chain 11155111 broadcast/DeployAllAndSetup.s.sol/11155111/run-1746581238.json, broadcast/DeployAllAndSetup.s.sol/11155111/run-latest.json	Included deployment sequences and receipts covering CREATE2 deployments and addStake CALL with metadata.
Broadcast artifacts — chain 11155420 broadcast/DeployAllAndSetup.s.sol/11155420/run-1746580595.json, broadcast/DeployAllAndSetup.s.sol/11155420/run-latest.json	Added full broadcast results: multiple CREATE2 deployments and an addStake CALL; detailed receipts and logs.
Broadcast artifacts — chain 114 broadcast/DeployAllAndSetup.s.sol/114/run-1746573145.json	New deployment manifest with CREATE2 deployments and addStake CALL; includes receipts and logs.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Deployer
  participant Factory as ModularEtherspotWalletFactory
  participant Wallet as ModularEtherspotWallet
  participant Bootstrap
  participant Validator as MultipleOwnerECDSAValidator
  participant Hook as HookMultiPlexer
  Note over Deployer: Broadcast DeployAllAndSetup.s.sol (multi-chain runs)
  Deployer->>Factory: CREATE2 deploy (constructor args)
  Deployer->>Wallet: CREATE2 deploy
  Deployer->>Bootstrap: CREATE2 deploy
  Deployer->>Validator: CREATE2 deploy
  Deployer->>Hook: CREATE2 deploy
  Note over Deployer,Factory: Post-deploy configuration
  Deployer->>Factory: addStake(address,uint32)
  Factory-->>Deployer: Receipt (status, logs)

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Boostrap hook multi plexer credible account module resource lock validator #11 — Touches deployment artifacts and README entries for Bootstrap/HookMultiPlexer; closely related to these broadcast/address updates.
• ResourceLockValidator, test suite cleanup and Soldeer integration #6 — Updates deployment artifacts and addresses (including HookMultiPlexer and factory deployments) that align with the added broadcast files.

Suggested reviewers

• ch4r10t33r
• kanthgithub

Poem

I thump the ground—deployments bloom,
New hooks and wallets leave the warren’s womb.
Addresses hop to fresher clover,
Broadcast trails across each rover.
With staked resolve, we onward scoot—🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	While the description and motivation sections briefly outline that the wallet factory was updated and contracts require redeployment, the testing section is empty and lacks any detail on how these changes were validated, and the “Types of changes” checkboxes are left unset, so critical information on test coverage and change classification is missing.	Please populate the “How Has This Been Tested?” section with details of your testing procedure, environment, and results, and mark the appropriate box in “Types of changes” to indicate whether this is a bug fix, new feature, or breaking change.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title “Wallet factory upgrade and redeploy contracts” concisely captures the primary purpose of the pull request, highlighting both the upgrade to the wallet factory and the need to redeploy related contracts without unnecessary detail or noise.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 5

🧹 Nitpick comments (5)

broadcast/DeployAllAndSetup.s.sol/114/run-1746573145.json (1)

1-303: Trim heavy bytecode in VCS or standardize run-latest.

These artifacts include full initcode “input” blobs and per-tx receipts; consider keeping only run-latest per network and git-ignoring timestamped runs to reduce repo churn/bloat.

broadcast/DeployAllAndSetup.s.sol/11155111/run-latest.json (1)

1-224: Align artifact naming across networks.

You committed run-latest for 11155111 but timestamped files for others. Pick one convention (prefer run-latest + retain last timestamped) for consistency.

broadcast/DeployAllAndSetup.s.sol/100/run-1748428685.json (1)

7-8: Normalize address casing.

contractAddress fields are lowercased while args use checksummed addresses. Standardize to EIP‑55 casing to reduce copy/paste errors.

Also applies to: 29-31

broadcast/DeployAllAndSetup.s.sol/1/run-1748432402.json (2)

102-121: Mainnet staking amount.

Re-validate 0.01 ETH stake and 86400s delay vs EntryPoint requirements and your alerting SLOs; consider higher buffer on mainnet.

---

1-259: Record CREATE2 salts for reproducibility.

Artifacts don't capture salts used for each CREATE2. Add a small JSON alongside (per tx: contractName, salt, initCodeHash) so others can deterministically recompute addresses.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 40b8b02 and 66afe7b.

📒 Files selected for processing (14)

• README.md (1 hunks)
• broadcast/DeployAllAndSetup.s.sol/1/run-1748432402.json (1 hunks)
• broadcast/DeployAllAndSetup.s.sol/1/run-latest.json (1 hunks)
• broadcast/DeployAllAndSetup.s.sol/10/run-1748443142.json (1 hunks)
• broadcast/DeployAllAndSetup.s.sol/10/run-latest.json (1 hunks)
• broadcast/DeployAllAndSetup.s.sol/100/run-1748428685.json (1 hunks)
• broadcast/DeployAllAndSetup.s.sol/100/run-latest.json (1 hunks)
• broadcast/DeployAllAndSetup.s.sol/10200/run-1746573005.json (1 hunks)
• broadcast/DeployAllAndSetup.s.sol/10200/run-latest.json (1 hunks)
• broadcast/DeployAllAndSetup.s.sol/11155111/run-1746581238.json (1 hunks)
• broadcast/DeployAllAndSetup.s.sol/11155111/run-latest.json (1 hunks)
• broadcast/DeployAllAndSetup.s.sol/11155420/run-1746580595.json (1 hunks)
• broadcast/DeployAllAndSetup.s.sol/11155420/run-latest.json (1 hunks)
• broadcast/DeployAllAndSetup.s.sol/114/run-1746573145.json (1 hunks)

🔇 Additional comments (7)

broadcast/DeployAllAndSetup.s.sol/114/run-1746573145.json (3)

28-35: Confirm factory constructor args (impl, owner).

Arguments point to wallet impl 0x62Fdd… and owner 0x09FD4F…. Please confirm this EOA is the intended production owner and that no rotation is required before mainnet parity.

---

87-99: Stake amount/delay sanity-check.

addStake sends 0x2386f26fc10000 (≈0.01 ETH) with delay 86400s. Validate this meets your bundler/AA infra minimums and monitoring alerts (insufficient stake can halt ops).

---

10-15: Singleton factory availability on chain 114.

Deploys via 0x4e59…; verify this CREATE2 deployer is present on chain 114 and matches your tooling assumptions. If not guaranteed, document the alternative path.

broadcast/DeployAllAndSetup.s.sol/11155111/run-latest.json (1)

23-43: Post-deploy verification on Sepolia.

Ensure contracts at listed addresses are verified on Etherscan/Sourcify and tagged with the same compiler settings; otherwise dev UX suffers.

broadcast/DeployAllAndSetup.s.sol/100/run-1748428685.json (2)

83-100: HookMultiPlexer deployed — sync docs/clients.

New HookMultiPlexer at 0xdca918… (chain 100). Ensure README/address-registry and any client configs include it, and note whether it’s optional or required.

---

1-259: Verify run artifacts and parameters consistency
No run-*.json artifacts were detected under broadcast/DeployAllAndSetup.s.sol. Please manually confirm that the deployed ModularEtherspotWallet (0x62fdd1382b0182f2cc40badea6e5de0ccb2d6488) and ModularEtherspotWalletFactory (0x38cc0eddd3a944ca17981e0a19470d2298b8d43a) addresses, as well as the addStake(address,uint32) parameters (value=0x2386f26fc10000 wei; delay=86400 s), are correct and consistent across all broadcast outputs.

broadcast/DeployAllAndSetup.s.sol/1/run-1748432402.json (1)

83-100: HookMultiPlexer on mainnet — operational checklist.

Confirm:

• Access controls and upgradability model documented.
• Emission/Hook ordering matches off-chain expectations.
• Backward compatibility with existing wallets.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

HookMultiPlexer transaction missing here as well.

This network’s artifact also stops after the validator deployment. Without the HookMultiPlexer CREATE2 entry (and receipt) the deployment set is inconsistent with the README and other environments. Please ensure the multiplexer is deployed and recorded in this JSON before shipping.

🤖 Prompt for AI Agents

In broadcast/DeployAllAndSetup.s.sol/10200/run-latest.json around lines 3-103
the HookMultiPlexer CREATE2 deployment is missing causing the run-latest.json to
end after the validator deployment and be inconsistent with README/other
environments; add a complete CREATE2 entry for HookMultiPlexer (hash,
transactionType: "CREATE2", contractName: "HookMultiPlexer", contractAddress,
function:null, arguments:null, and a full transaction object including from, to
(init code deployer), gas, value, input (contract init bytecode/constructor
calldata), nonce and chainId) and include its receipt/related fields in the same
list at the correct sequence position so the deployment set matches README and
other networks. Ensure the address and init calldata match the actual deployed
artifact and include the matching receipt/hash to keep the JSON consistent.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

HookMultiPlexer deployment omitted.

Just like the 11155420 broadcast, this artifact never deploys the HookMultiPlexer even though the release notes/docs now list an address for it. Anyone replaying this JSON will end up with an incomplete environment. Please regenerate the broadcast with the HookMultiPlexer CREATE2 transaction (and corresponding receipt) included.

🤖 Prompt for AI Agents

In broadcast/DeployAllAndSetup.s.sol/11155111/run-1746581238.json around lines 3
to 103, the CREATE2 deployment entry list omits the HookMultiPlexer deploy (so
replaying this broadcast produces an incomplete environment); regenerate the
broadcast and insert the HookMultiPlexer CREATE2 transaction and its
corresponding receipt into the JSON (with correct contractName, contractAddress,
from/to, gas/value/input/nonce/chainId, and any logs/receipt fields), place it
in the same sequence as other CREATE2 deployments, and ensure the reported
HookMultiPlexer address matches the release notes/docs so downstream replays
produce a complete environment.

[coderabbitai]

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Commit hash linkage.

Field "commit": "05e41bb" — confirm it matches the PR head so consumers can reproduce the exact build.

---

🏁 Script executed:

#!/bin/bash
# Verify commit hash matches repo HEAD (short)
git rev-parse --short HEAD
jq -r '.commit' broadcast/DeployAllAndSetup.s.sol/11155111/run-latest.json

Length of output: 15

---

Update commit hash in run-latest.json to match repo HEAD
broadcast/DeployAllAndSetup.s.sol/11155111/run-latest.json: field "commit": "05e41bb" must be updated to "66afe7b" (output of git rev-parse --short HEAD).

🤖 Prompt for AI Agents

In broadcast/DeployAllAndSetup.s.sol/11155111/run-latest.json around lines 221
to 223, the "commit" field is outdated ("05e41bb"); update its value to the
current repo HEAD short hash "66afe7b" by replacing the string so the JSON
reflects the latest commit.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Missing HookMultiPlexer deployment in this broadcast.

The updated rollout is supposed to include a HookMultiPlexer, but this transaction list stops at the validator deployment and stake call—there is no CREATE2 for the multiplexer. Because of that, the README and the other chain artifacts point to a contract that was never deployed on 11155420. Please rerun the script (or add the missing transaction) so the artifact faithfully captures the full deployment set.

🤖 Prompt for AI Agents

In broadcast/DeployAllAndSetup.s.sol/11155420/run-latest.json around lines 3 to
103, the broadcast is missing the CREATE2 deployment entry for the
HookMultiPlexer (the rollout was updated to include it but the multiplexer
CREATE2 is absent), so the artifact/README references a contract that was never
deployed on chain 11155420; fix by re-running the deployment script to produce a
run-latest.json that contains the HookMultiPlexer CREATE2 transaction (or
manually insert a matching CREATE2 JSON object) including contractName
"HookMultiPlexer", its contractAddress, the full transaction object
(from/to/gas/value/input/nonce/chainId) and any constructor arguments, then
update the README and other chain artifacts to reference the newly added
deployment entry.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

HookMultiPlexer row is out of sync with provided deployments.

The table now advertises a new HookMultiPlexer address, but none of the refreshed broadcast artifacts for chains 11155420, 11155111, or 10200 show a deployment of this contract. Until the contract is actually live (and recorded in the artifacts) this row will mislead anyone trying to verify the rollout. Please either add the missing deployments or revert the documentation update.

🤖 Prompt for AI Agents

README.md lines 75-79: The HookMultiPlexer table row claims a deployed address
that isn’t present in the refreshed broadcast artifacts for chains 11155420,
11155111, or 10200; fix by either (A) adding the missing deployment artifacts
and broadcast entries for HookMultiPlexer (ensure the contract was actually
deployed to those chains, include the address in the proper artifacts directory
and regenerate any deployment manifests) or (B) revert/remove the
HookMultiPlexer row from the table so the README matches the recorded artifacts;
update the README commit accordingly and ensure CI or checks that compare docs
vs artifacts pass.