allow relative paths in run_external_tasks, resolving against parent base path/URL#114
Merged
allow relative paths in run_external_tasks, resolving against parent base path/URL#114
run_external_tasks, resolving against parent base path/URL#114Conversation
run_external_tasks, resoving against parent base path/URLrun_external_tasks, resolving against parent base path/URL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR allows adding external playbooks with relative paths like this:
relative paths are resolved relative to the parent base directory, which allows nested playbooks with relative paths even from URLs.
eg. if the above playbook is loaded from http://example.com/my_tests/test.yaml, the referenced external_tasks playbook is loaded from http://example.com/some_path/test.yaml (http://example.com/my_tests/../some_path/test.yaml)