fix(download): skip blob sidecar download when Fulu fork is active #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic now checks if the "fulu" fork is active for the current epoch. If Fulu is active, blob sidecars are no longer included in blocks, so the download is skipped to prevent unnecessary operations and potential errors.
…sensus clients Refactor the integration workflow to iterate over both 'mainnet' and 'holesky' networks. This expands test coverage to ensure compatibility with the Holesky testnet, dynamically selecting the appropriate beacon node URL secret based on the network being tested.
…n workflow This change separates the logic for determining the `beacon_node_url` into its own step (`Set beacon node URL`). This improves readability and maintainability of the workflow by avoiding a complex ternary expression directly in the action input.
…tests Introduce a `consensus_image` input in the checkpoint-sync action and use matrix strategy in `integration.yaml` to pass specific Docker images for each consensus client and network combination. This allows for testing against pinned versions instead of relying on `:latest` tags, improving test stability and reproducibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.