Skip to content

Conversation

ndeto
Copy link

@ndeto ndeto commented May 23, 2025

This PR adds txpool-viz as an additional service to this package

@ndeto ndeto force-pushed the ndeto/feat/add-txpool-viz branch from 65cd9fb to f5f5dfc Compare May 27, 2025 19:09
@barnabasbusa
Copy link
Collaborator

I know the PR is still in draft, but I think it would be good if txpool viz params would have ways to modify default docker image, add extra runtime params, and add env variables. (Similar to all our toolings)

@ndeto
Copy link
Author

ndeto commented May 29, 2025

I know the PR is still in draft, but I think it would be good if txpool viz params would have ways to modify default docker image, add extra runtime params, and add env variables. (Similar to all our toolings)

Def 💯 👌🏾

@ndeto ndeto force-pushed the ndeto/feat/add-txpool-viz branch from 785b195 to d526d42 Compare June 2, 2025 13:09
@ndeto ndeto force-pushed the ndeto/feat/add-txpool-viz branch 10 times, most recently from 4ccbcc7 to 3ce87f5 Compare June 24, 2025 11:53
@ndeto ndeto marked this pull request as ready for review June 24, 2025 11:54
@ndeto ndeto force-pushed the ndeto/feat/add-txpool-viz branch 7 times, most recently from a5380f3 to 1985d40 Compare June 26, 2025 16:20
@ndeto
Copy link
Author

ndeto commented Jun 30, 2025

I know the PR is still in draft, but I think it would be good if txpool viz params would have ways to modify default docker image, add extra runtime params, and add env variables. (Similar to all our toolings)

Hi @barnabasbusa , This is ready for a review.

@barnabasbusa
Copy link
Collaborator

Could you please add readme ?

@barnabasbusa
Copy link
Collaborator

Could you please add some docs to the readme, and fix the merge conflicts?

@ndeto ndeto force-pushed the ndeto/feat/add-txpool-viz branch from 0289e91 to 4b08451 Compare July 17, 2025 11:26
@ndeto ndeto force-pushed the ndeto/feat/add-txpool-viz branch from 4b08451 to a8f829b Compare July 17, 2025 11:28
@ndeto
Copy link
Author

ndeto commented Jul 17, 2025

@barnabasbusa Updated.

@barnabasbusa
Copy link
Collaborator

Could you please add txpool_viz to

	modified:   .github/tests/mix-public.yaml
	modified:   .github/tests/mix-with-tools-mev.yaml
	modified:   .github/tests/mix-with-tools-minimal.yaml
	modified:   .github/tests/mix-with-tools.yaml

And make sure the CI jobs are not failing

@barnabasbusa
Copy link
Collaborator

I've tried to push to your pr the test cases but I don't seem to have write access to your pr.

@barnabasbusa
Copy link
Collaborator

Also it seems like you are missing default txpool viz parameters in input parser.

Probably want something like:

def get_default_txpool_viz_params():
    return {
        "image": constants.DEFAULT_TXPOOL_VIZ_IMAGE,
        "min_cpu": False,
        "max_cpu": False,
        "min_mem": False,
        "max_mem": False,
        "extra_args": [],
        "polling": {
            "interval": "0.5s",
            "timeout": "3s",
        },
        "filters": {
            "min_gas_price": "1gwei",
        },
        "focil_enabled": "false",
        "log_level": "info",
        "env": {},
    }

and set the txpool_viz_params by default in Line 1067

@ndeto
Copy link
Author

ndeto commented Jul 18, 2025

@barnabasbusa , Kindly trigger the tests. I have also granted write access from the fork side incase you need to trigger tests again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants