-
Notifications
You must be signed in to change notification settings - Fork 287
feat: add txpool-viz #1040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add txpool-viz #1040
Conversation
65cd9fb
to
f5f5dfc
Compare
I know the PR is still in draft, but I think it would be good if txpool viz params would have ways to modify default docker image, add extra runtime params, and add env variables. (Similar to all our toolings) |
Def 💯 👌🏾 |
785b195
to
d526d42
Compare
4ccbcc7
to
3ce87f5
Compare
a5380f3
to
1985d40
Compare
Hi @barnabasbusa , This is ready for a review. |
Could you please add readme ? |
Could you please add some docs to the readme, and fix the merge conflicts? |
0289e91
to
4b08451
Compare
4b08451
to
a8f829b
Compare
@barnabasbusa Updated. |
Could you please add txpool_viz to
And make sure the CI jobs are not failing |
I've tried to push to your pr the test cases but I don't seem to have write access to your pr. |
Also it seems like you are missing default txpool viz parameters in input parser. Probably want something like: def get_default_txpool_viz_params():
return {
"image": constants.DEFAULT_TXPOOL_VIZ_IMAGE,
"min_cpu": False,
"max_cpu": False,
"min_mem": False,
"max_mem": False,
"extra_args": [],
"polling": {
"interval": "0.5s",
"timeout": "3s",
},
"filters": {
"min_gas_price": "1gwei",
},
"focil_enabled": "false",
"log_level": "info",
"env": {},
} and set the txpool_viz_params by default in Line 1067 |
@barnabasbusa , Kindly trigger the tests. I have also granted write access from the fork side incase you need to trigger tests again. |
This PR adds txpool-viz as an additional service to this package