Skip to content

Conversation

tedim52
Copy link
Collaborator

@tedim52 tedim52 commented Jun 19, 2025

The remove_service was preventing enclave edits from working on params that contained shadowforking configs such as:

participants:
 - el_extra_params: []
network_params:
   network: hoodi-shadowfork
persistent: true

Removing the remove_service allows the following edit to skip instructions that haven't changed (pulling shadowfork data, which is very time consuming) while still updating instructions that do change, like updating service config of el node to have the extra cmd arg flag:

participants:
 - el_extra_params: ["--miner.gaslimit=78000000"]
network_params:
   network: hoodi-shadowfork
persistent: true

image

This is in the Kurtosis docs but it's pretty hidden:

It's good to callout here that a few Kurtosis instructions are fundamentally incompatible with the concept of idempotency. The use of one of those instructions in the package will make the plans not resolvable, and Kurtosis will default to the "naive" execution strategy of running the submitted plan on top of the current plan, without even trying the overlap them. Those instructions currently are:

remove_service
start_service
stop_service

https://docs.kurtosis.com/advanced-concepts/how-do-enclave-edits-work/

TODO: add a callout in Kurtosis CLI to inform users enclave edits won't work with remove_service so they don't have to read the docs

@tedim52 tedim52 changed the title Tedi/removeremove fix: shadowfork enclave edits Jun 19, 2025
@barnabasbusa barnabasbusa enabled auto-merge (squash) June 20, 2025 05:48
@barnabasbusa barnabasbusa merged commit 63689ec into ethpandaops:main Jun 20, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants