fix: shadowfork enclave edits #1070
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
remove_service
was preventing enclave edits from working on params that contained shadowforking configs such as:Removing the
remove_service
allows the following edit to skip instructions that haven't changed (pulling shadowfork data, which is very time consuming) while still updating instructions that do change, like updating service config of el node to have the extra cmd arg flag:This is in the Kurtosis docs but it's pretty hidden:
https://docs.kurtosis.com/advanced-concepts/how-do-enclave-edits-work/
TODO: add a callout in Kurtosis CLI to inform users enclave edits won't work with
remove_service
so they don't have to read the docs